Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2815403002: WebView: Refactor PlatformServiceBridge.getInstance() (Closed)

Created:
3 years, 8 months ago by paulmiller
Modified:
3 years, 8 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, kalyank, sadrul, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: Refactor PlatformServiceBridge.getInstance() Fold getOrCreateInstance back into getInstance, since construction no longer requires a Context. This partially reverts 2009b0e3. BUG=706495 Review-Url: https://codereview.chromium.org/2815403002 Cr-Commit-Position: refs/heads/master@{#465264} Committed: https://chromium.googlesource.com/chromium/src/+/00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -52 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +1 line, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java View 2 chunks +29 lines, -40 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
paulmiller
On 2017/04/13 21:38:32, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:tobiasjs@chromium.org PTAL
3 years, 8 months ago (2017-04-13 21:38:48 UTC) #3
Tobias Sargeant
On 2017/04/13 21:38:48, paulmiller wrote: > On 2017/04/13 21:38:32, paulmiller wrote: > > mailto:paulmiller@chromium.org changed ...
3 years, 8 months ago (2017-04-18 08:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815403002/1
3 years, 8 months ago (2017-04-18 16:11:49 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 16:40:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00b225ddd0a5b1953d45ad4fdd22...

Powered by Google App Engine
This is Rietveld 408576698