DevTools: Add more views to command menu

DevTools: Add more views to command menu

BUG=712360
Review-Url: https://codereview.chromium.org/2815373003
Cr-Commit-Position: refs/heads/master@{#465149}
Committed: https://chromium.googlesource.com/chromium/src/+/085a7270212da1b640e4c6b98befab821447f741

[einbinder, 2017-04-17 22:02:48]

Description was changed from

==========
DevTools: Add more views to command menu

BUG=
==========

to

==========
DevTools: Add more views to command menu

BUG=712360
==========

[einbinder, 2017-04-17 22:02:57]

einbinder@chromium.org changed reviewers:
+ pfeldman@chromium.org

[einbinder, 2017-04-17 22:02:58]

ptal

[pfeldman, 2017-04-17 23:15:54]

https://codereview.chromium.org/2815373003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js
(right):

https://codereview.chromium.org/2815373003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js:96: if
(location === 'panel')
We are missing a resolver for the panels, you should not need to special-case
this one if you created a resolver.

[einbinder, 2017-04-17 23:52:06]

https://codereview.chromium.org/2815373003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js
(right):

https://codereview.chromium.org/2815373003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js:96: if
(location === 'panel')
On 2017/04/17 at 23:15:54, pfeldman wrote:
> We are missing a resolver for the panels, you should not need to special-case
this one if you created a resolver.

Done.

[pfeldman, 2017-04-17 23:55:15]

lgtm

[einbinder, 2017-04-18 00:32:28]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-18 00:32:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 02:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:39:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-04-18 04:49:53]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:50:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 05:38:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492490993706600,
"parent_rev": "3c8ebf96c1e2432763cac1a6fa97cf5217a8728c", "commit_rev":
"085a7270212da1b640e4c6b98befab821447f741"}

[commit-bot: I haz the power, 2017-04-18 05:39:02]

Description was changed from

==========
DevTools: Add more views to command menu

BUG=712360
==========

to

==========
DevTools: Add more views to command menu

BUG=712360

Review-Url: https://codereview.chromium.org/2815373003
Cr-Commit-Position: refs/heads/master@{#465149}
Committed:
https://chromium.googlesource.com/chromium/src/+/085a7270212da1b640e4c6b98bef...
==========

[commit-bot: I haz the power, 2017-04-18 05:39:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/085a7270212da1b640e4c6b98bef...