Revert of Move securityCheck out of V8WrapperInstantiationScope

Revert of Move securityCheck out of V8WrapperInstantiationScope (patchset #13 id:240001 of https://codereview.chromium.org/2745313003/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=711373

The DCHECK in ScriptWrappable::Wrap indicates that we do not properly handle an empty wrapper being returned by V8DOMWrapper::CreateWrapper. So a failed security check would cause this crash. 

A potential short-term fix would be to just return a wrapper regardless of whether the security check passed or failed (which is what the previous implementation did)?

Original issue's description:
> Move securityCheck out of V8WrapperInstantiationScope
> 
> Moving V8DOMWrapper.h/cpp to platform/bindings is blocked by V8WrapperInstantiationScope::securityCheck and V8WrapperInstantiationScope::convertException. Both of these methods use toLocalFrame/toDOMWindow, and cannot be moved to platform/.
> 
> This CL moves the security check into WrapperCreationSecurityCheck. WrapperCreationSecurityCheck only holds a function pointer and will be moved into platform/bindings. The implementation of the security check is moved to BindingSecurity (in bindings/core), and the function pointer is set to point to the implementation inside core/. 
> 
> BUG=682322
> 
> Review-Url: https://codereview.chromium.org/2745313003
> Cr-Commit-Position: refs/heads/master@{#463621}
> Committed: https://chromium.googlesource.com/chromium/src/+/3f7eac384ee02371be4972ba0647082bf6599eb1

TBR=haraken@chromium.org,jbroman@chromium.org,jochen@chromium.org,yukishiino@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682322, 711373
Review-Url: https://codereview.chromium.org/2815373002
Cr-Commit-Position: refs/heads/master@{#464786}
Committed: https://chromium.googlesource.com/chromium/src/+/2636f41f63df88af492932e306bae2553f73d1ce

[adithyas, 2017-04-13 18:40:23]

Created Revert of Move securityCheck out of V8WrapperInstantiationScope

[adithyas, 2017-04-13 18:41:09]

The CQ bit was checked by adithyas@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:41:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adithyas, 2017-04-13 18:44:17]

Description was changed from

==========
Revert of Move securityCheck out of V8WrapperInstantiationScope (patchset #13
id:240001 of https://codereview.chromium.org/2745313003/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=711373

The DCHECK in ScriptWrappable::Wrap indicates that we do not properly handle an
empty wrapper being returned by V8DOMWrapper::CreateWrapper. So a failed
security check would cause this crash. 

A potential short-term fix would be to just return a wrapper regardless of
whether the security check passed or failed (which is what the previous
implementation did)?

Original issue's description:
> Move securityCheck out of V8WrapperInstantiationScope
> 
> Moving V8DOMWrapper.h/cpp to platform/bindings is blocked by
V8WrapperInstantiationScope::securityCheck and
V8WrapperInstantiationScope::convertException. Both of these methods use
toLocalFrame/toDOMWindow, and cannot be moved to platform/.
> 
> This CL moves the security check into WrapperCreationSecurityCheck.
WrapperCreationSecurityCheck only holds a function pointer and will be moved
into platform/bindings. The implementation of the security check is moved to
BindingSecurity (in bindings/core), and the function pointer is set to point to
the implementation inside core/. 
> 
> BUG=682322
> 
> Review-Url: https://codereview.chromium.org/2745313003
> Cr-Commit-Position: refs/heads/master@{#463621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/3f7eac384ee02371be4972ba0647...

TBR=haraken@chromium.org,jbroman@chromium.org,jochen@chromium.org,yukishiino@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682322
==========

to

==========
Revert of Move securityCheck out of V8WrapperInstantiationScope (patchset #13
id:240001 of https://codereview.chromium.org/2745313003/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=711373

The DCHECK in ScriptWrappable::Wrap indicates that we do not properly handle an
empty wrapper being returned by V8DOMWrapper::CreateWrapper. So a failed
security check would cause this crash. 

A potential short-term fix would be to just return a wrapper regardless of
whether the security check passed or failed (which is what the previous
implementation did)?

Original issue's description:
> Move securityCheck out of V8WrapperInstantiationScope
> 
> Moving V8DOMWrapper.h/cpp to platform/bindings is blocked by
V8WrapperInstantiationScope::securityCheck and
V8WrapperInstantiationScope::convertException. Both of these methods use
toLocalFrame/toDOMWindow, and cannot be moved to platform/.
> 
> This CL moves the security check into WrapperCreationSecurityCheck.
WrapperCreationSecurityCheck only holds a function pointer and will be moved
into platform/bindings. The implementation of the security check is moved to
BindingSecurity (in bindings/core), and the function pointer is set to point to
the implementation inside core/. 
> 
> BUG=682322
> 
> Review-Url: https://codereview.chromium.org/2745313003
> Cr-Commit-Position: refs/heads/master@{#463621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/3f7eac384ee02371be4972ba0647...

TBR=haraken@chromium.org,jbroman@chromium.org,jochen@chromium.org,yukishiino@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682322, 711373
==========

[haraken, 2017-04-13 22:08:06]

LGTM

[commit-bot: I haz the power, 2017-04-13 22:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 22:43:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuki, 2017-04-14 06:44:18]

LGTM.

[jbroman, 2017-04-14 18:26:04]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:26:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 20:20:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492194364643340, "parent_rev":
"bebfdd95c7fdc587686da076262cb9292696e909", "commit_rev":
"2636f41f63df88af492932e306bae2553f73d1ce"}

[commit-bot: I haz the power, 2017-04-14 20:20:56]

Description was changed from

==========
Revert of Move securityCheck out of V8WrapperInstantiationScope (patchset #13
id:240001 of https://codereview.chromium.org/2745313003/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=711373

The DCHECK in ScriptWrappable::Wrap indicates that we do not properly handle an
empty wrapper being returned by V8DOMWrapper::CreateWrapper. So a failed
security check would cause this crash. 

A potential short-term fix would be to just return a wrapper regardless of
whether the security check passed or failed (which is what the previous
implementation did)?

Original issue's description:
> Move securityCheck out of V8WrapperInstantiationScope
> 
> Moving V8DOMWrapper.h/cpp to platform/bindings is blocked by
V8WrapperInstantiationScope::securityCheck and
V8WrapperInstantiationScope::convertException. Both of these methods use
toLocalFrame/toDOMWindow, and cannot be moved to platform/.
> 
> This CL moves the security check into WrapperCreationSecurityCheck.
WrapperCreationSecurityCheck only holds a function pointer and will be moved
into platform/bindings. The implementation of the security check is moved to
BindingSecurity (in bindings/core), and the function pointer is set to point to
the implementation inside core/. 
> 
> BUG=682322
> 
> Review-Url: https://codereview.chromium.org/2745313003
> Cr-Commit-Position: refs/heads/master@{#463621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/3f7eac384ee02371be4972ba0647...

TBR=haraken@chromium.org,jbroman@chromium.org,jochen@chromium.org,yukishiino@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682322, 711373
==========

to

==========
Revert of Move securityCheck out of V8WrapperInstantiationScope (patchset #13
id:240001 of https://codereview.chromium.org/2745313003/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=711373

The DCHECK in ScriptWrappable::Wrap indicates that we do not properly handle an
empty wrapper being returned by V8DOMWrapper::CreateWrapper. So a failed
security check would cause this crash. 

A potential short-term fix would be to just return a wrapper regardless of
whether the security check passed or failed (which is what the previous
implementation did)?

Original issue's description:
> Move securityCheck out of V8WrapperInstantiationScope
> 
> Moving V8DOMWrapper.h/cpp to platform/bindings is blocked by
V8WrapperInstantiationScope::securityCheck and
V8WrapperInstantiationScope::convertException. Both of these methods use
toLocalFrame/toDOMWindow, and cannot be moved to platform/.
> 
> This CL moves the security check into WrapperCreationSecurityCheck.
WrapperCreationSecurityCheck only holds a function pointer and will be moved
into platform/bindings. The implementation of the security check is moved to
BindingSecurity (in bindings/core), and the function pointer is set to point to
the implementation inside core/. 
> 
> BUG=682322
> 
> Review-Url: https://codereview.chromium.org/2745313003
> Cr-Commit-Position: refs/heads/master@{#463621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/3f7eac384ee02371be4972ba0647...

TBR=haraken@chromium.org,jbroman@chromium.org,jochen@chromium.org,yukishiino@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=682322, 711373

Review-Url: https://codereview.chromium.org/2815373002
Cr-Commit-Position: refs/heads/master@{#464786}
Committed:
https://chromium.googlesource.com/chromium/src/+/2636f41f63df88af492932e306ba...
==========

[commit-bot: I haz the power, 2017-04-14 20:20:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2636f41f63df88af492932e306ba...