Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: media/formats/mpeg/mpeg_audio_stream_parser_base.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Actually fix fuzzers. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mpeg/mpeg_audio_stream_parser_base.h
diff --git a/media/formats/mpeg/mpeg_audio_stream_parser_base.h b/media/formats/mpeg/mpeg_audio_stream_parser_base.h
index febd814efed26224bbf42d94298b69fd4ea2a0f2..f0712380ef4421cbc9418949ece36ab14af49a1d 100644
--- a/media/formats/mpeg/mpeg_audio_stream_parser_base.h
+++ b/media/formats/mpeg/mpeg_audio_stream_parser_base.h
@@ -41,7 +41,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {
const EncryptedMediaInitDataCB& encrypted_media_init_data_cb,
const NewMediaSegmentCB& new_segment_cb,
const EndMediaSegmentCB& end_of_segment_cb,
- const scoped_refptr<MediaLog>& media_log) override;
+ MediaLog* media_log) override;
void Flush() override;
bool Parse(const uint8_t* buf, int size) override;
@@ -85,7 +85,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {
bool* metadata_frame,
std::vector<uint8_t>* extra_data) const = 0;
- const scoped_refptr<MediaLog>& media_log() const { return media_log_; }
+ MediaLog* media_log() const { return media_log_; }
private:
enum State {
@@ -141,7 +141,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {
NewBuffersCB new_buffers_cb_;
NewMediaSegmentCB new_segment_cb_;
EndMediaSegmentCB end_of_segment_cb_;
- scoped_refptr<MediaLog> media_log_;
+ MediaLog* media_log_;
ByteQueue queue_;

Powered by Google App Engine
This is Rietveld 408576698