media/formats/mpeg/mpeg1_audio_stream_parser.h - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg1_audio_stream_parser.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Actually fix fuzzers. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mpeg/mpeg1_audio_stream_parser.h

diff --git a/media/formats/mpeg/mpeg1_audio_stream_parser.h b/media/formats/mpeg/mpeg1_audio_stream_parser.h

index fc0ce35dac9fe80827cae66c93be7b3db6e66dfb..f162bd105556fa74f7c3d848d20cd80642da1f61 100644

--- a/media/formats/mpeg/mpeg1_audio_stream_parser.h

+++ b/media/formats/mpeg/mpeg1_audio_stream_parser.h

@@ -64,7 +64,7 @@ class MEDIA_EXPORT MPEG1AudioStreamParser : public MPEGAudioStreamParserBase {

// Parses the header starting at |data|.

// Assumption: size of array |data| should be at least |kHeaderSize|.

// Returns false if the header is not valid.

- static bool ParseHeader(const scoped_refptr<MediaLog>& media_log,

+ static bool ParseHeader(MediaLog* media_log,

const uint8_t* data,

Header* header);