Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2815303003: [qcms] Disable advisory asserts when running in libfuzzer (Closed)

Created:
3 years, 8 months ago by Noel Gordon
Modified:
3 years, 8 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[qcms] Disable advisory asserts when running in libfuzzer Some QCMS assert() conditions are purely advisory so disable those when running the code in libfuzzer. Other qcms assert() conditions are real errors and should be enabled even when fuzzing. TBR=ccameron@chromium.org BUG=711418 Review-Url: https://codereview.chromium.org/2815303003 Cr-Commit-Position: refs/heads/master@{#464697} Committed: https://chromium.googlesource.com/chromium/src/+/188c1056bbfb9c98eca691c12f5641d4204f6066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M third_party/qcms/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/qcms/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/src/chain.c View 4 chunks +9 lines, -3 lines 0 comments Download
M third_party/qcms/src/iccread.c View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/qcms/src/transform.c View 8 chunks +13 lines, -7 lines 0 comments Download
M third_party/qcms/src/transform_util.c View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (11 generated)
Noel Gordon
PTAL when you have time.
3 years, 8 months ago (2017-04-14 07:01:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815303003/1
3 years, 8 months ago (2017-04-14 07:01:54 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 07:09:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/188c1056bbfb9c98eca691c12f56...

Powered by Google App Engine
This is Rietveld 408576698