Improve performance of base::ListValue::Append*

Improve performance of base::ListValue::Append*

base::ListValue's underlying storage recently switched to value semantics,
however this is not yet completely reflected in the implementation of its API.
This change fixes this by updating the convenience variants of Append to
directly write to the underlying storage. This is likely to improve performance
due to the removal of temporary unique_ptrs.

R=brettw@chromium.org
BUG=646113
Review-Url: https://codereview.chromium.org/2815303002
Cr-Commit-Position: refs/heads/master@{#465193}
Committed: https://chromium.googlesource.com/chromium/src/+/1652c0cc691916d61dc15f498e6af183e1237f0d

[jdoerrie, 2017-04-13 10:57:10]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 10:57:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 11:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 11:53:25]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-04-13 12:02:00]

Hi Brett, please review. These APIs will be deprecated soon, but they should be
as efficient as possible until they are finally deleted.

[brettw, 2017-04-14 18:11:41]

lgtm

[jdoerrie, 2017-04-18 08:55:09]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-04-18 08:55:09]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2815303002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-18 08:55:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 10:02:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492505709005980,
"parent_rev": "b7e73982aefe2f48be09b7e31a5ddc2346371f5f", "commit_rev":
"1652c0cc691916d61dc15f498e6af183e1237f0d"}

[commit-bot: I haz the power, 2017-04-18 10:02:21]

Description was changed from

==========
Improve performance of base::ListValue::Append*

base::ListValue's underlying storage recently switched to value semantics,
however this is not yet completely reflected in the implementation of its API.
This change fixes this by updating the convenience variants of Append to
directly write to the underlying storage. This is likely to improve performance
due to the removal of temporary unique_ptrs.

R=brettw@chromium.org
BUG=646113
==========

to

==========
Improve performance of base::ListValue::Append*

base::ListValue's underlying storage recently switched to value semantics,
however this is not yet completely reflected in the implementation of its API.
This change fixes this by updating the convenience variants of Append to
directly write to the underlying storage. This is likely to improve performance
due to the removal of temporary unique_ptrs.

R=brettw@chromium.org
BUG=646113

Review-Url: https://codereview.chromium.org/2815303002
Cr-Commit-Position: refs/heads/master@{#465193}
Committed:
https://chromium.googlesource.com/chromium/src/+/1652c0cc691916d61dc15f498e6a...
==========

[commit-bot: I haz the power, 2017-04-18 10:02:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1652c0cc691916d61dc15f498e6a...