Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2815283002: [turbofan] Let ChangeFloat64ToTagged canonicalize to Smi if possible. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Let ChangeFloat64ToTagged canonicalize to Smi if possible. When the incoming value to ChangeFloat64ToTagged is in Smi range, we represent it as Smi instead of a HeapNumber. This addresses a range of problems where TurboFan unnecessarily deoptimizes because an operation learned Smi feedback in Ignition, but was then confronted with a tagged HeapNumber in TurboFan, just because the value was also represented as unboxed double somewhere in the meantime. BUG=v8:6256 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2815283002 Cr-Commit-Position: refs/heads/master@{#44631} Committed: https://chromium.googlesource.com/v8/v8/+/385734bf11d3c4529cc30c553eef8c3e0d69afad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -31 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +55 lines, -1 line 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +27 lines, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 6 chunks +39 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-13 06:34:38 UTC) #1
Yang
On 2017/04/13 06:34:38, Benedikt Meurer wrote: lgtm. thanks.
3 years, 8 months ago (2017-04-13 06:36:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815283002/1
3 years, 8 months ago (2017-04-13 06:37:17 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 06:57:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/385734bf11d3c4529cc30c553eef8c3e0d6...

Powered by Google App Engine
This is Rietveld 408576698