Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2815263002: Move form-related files in core/html/shadow to core/html/forms. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, haraken, jchaffraix+rendering, je_julie, kinuko+watch, leviw+renderwatch, nektar+watch_chromium.org, nektarios, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move form-related files in core/html/shadow to core/html/forms. core/html/forms/OWNERS should be responsible for these files. This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2815263002 Cr-Commit-Position: refs/heads/master@{#464345} Committed: https://chromium.googlesource.com/chromium/src/+/bb6387452dae47fbceddc766960deb233e36c6c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4861 lines) Patch
M third_party/WebKit/Source/core/html/BUILD.gn View 6 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/ClearButtonElement.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/ClearButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeEditElement.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeEditElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeFieldElement.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeFieldElements.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeFieldElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeNumericFieldElement.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeNumericFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeSymbolicFieldElement.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/DateTimeSymbolicFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/SliderThumbElement.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/SliderThumbElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/SpinButtonElement.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/SpinButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/forms/TextControlInnerElements.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/html/shadow/ClearButtonElement.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/ClearButtonElement.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.h View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +0 lines, -872 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.h View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +0 lines, -234 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeFieldElements.h View 1 chunk +0 lines, -329 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeFieldElements.cpp View 1 chunk +0 lines, -794 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeNumericFieldElement.h View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeNumericFieldElement.cpp View 1 chunk +0 lines, -240 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.h View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp View 1 chunk +0 lines, -176 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/PickerIndicatorElement.h View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/PickerIndicatorElement.cpp View 1 chunk +0 lines, -181 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +0 lines, -473 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/SpinButtonElement.h View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp View 1 chunk +0 lines, -255 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.h View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +0 lines, -211 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderThumb.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderThumb.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSpinButton.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
tkent
yosin@, would you review this please?
3 years, 8 months ago (2017-04-13 05:22:36 UTC) #7
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-13 05:43:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815263002/1
3 years, 8 months ago (2017-04-13 05:43:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/361596)
3 years, 8 months ago (2017-04-13 07:22:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815263002/1
3 years, 8 months ago (2017-04-13 08:27:08 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 08:56:23 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb6387452dae47fbceddc766960d...

Powered by Google App Engine
This is Rietveld 408576698