Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 2815233002: [ios] Move ToolsMenuConfiguration to shared. (Closed)

Created:
3 years, 8 months ago by sczs
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Move ToolsMenuConfiguration to shared. BUG=682880 Review-Url: https://codereview.chromium.org/2815233002 Cr-Commit-Position: refs/heads/master@{#464438} Committed: https://chromium.googlesource.com/chromium/src/+/206ca2c9b0ec44066b9275badb2ae2f9bb748b4c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -143 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
D ios/chrome/browser/ui/tools_menu/tools_menu_configuration.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ios/chrome/browser/ui/tools_menu/tools_menu_configuration.mm View 1 chunk +0 lines, -72 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A ios/shared/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A + ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
sczs
PTAL https://codereview.chromium.org/2815233002/diff/1/ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm File ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm (left): https://codereview.chromium.org/2815233002/diff/1/ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm#oldcode9 ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.mm:9: #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h" Apparently only the forward declaration was ...
3 years, 8 months ago (2017-04-13 06:47:24 UTC) #2
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-13 14:51:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815233002/1
3 years, 8 months ago (2017-04-13 16:27:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 16:38:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/206ca2c9b0ec44066b9275badb2a...

Powered by Google App Engine
This is Rietveld 408576698