Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2815173002: Move empty.wav to media/base (Closed)

Created:
3 years, 8 months ago by tguilbert
Modified:
3 years, 8 months ago
Reviewers:
Ted C, xhwang, DaleCurtis
CC:
agrieve+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-media_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move empty.wav to media/base Currently, the MediaServerCrashListener uses an empty wav file to create the MediaPlayer it uses a watchdog to listen for server crashed. Empty.wav is in content/public/android. With the recent removal of the MediaThrottler, it is now possible to move empty.wav to media/base, in order to break the dependency on //content. BUG=707265 TEST= Review-Url: https://codereview.chromium.org/2815173002 Cr-Commit-Position: refs/heads/master@{#464479} Committed: https://chromium.googlesource.com/chromium/src/+/86670b9ee927163fffe528e93d8179100fae0b08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
D content/public/android/java/res/raw/empty.wav View Binary file 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
A + media/base/android/java/res/raw/empty.wav View Binary file 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaServerCrashListener.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
tguilbert
PTAL! tedchoc@ can you OWNERS review content/public/android/java/res? Thank you, Thomas
3 years, 8 months ago (2017-04-12 21:53:44 UTC) #2
DaleCurtis
I'm surprised this didn't fail a DEPS check or something. Is it because we have ...
3 years, 8 months ago (2017-04-13 00:05:59 UTC) #4
Ted C
On 2017/04/13 00:05:59, DaleCurtis wrote: > I'm surprised this didn't fail a DEPS check or ...
3 years, 8 months ago (2017-04-13 00:08:56 UTC) #5
xhwang
lgtm
3 years, 8 months ago (2017-04-13 00:21:36 UTC) #6
tguilbert
On 2017/04/13 00:21:36, xhwang_slow wrote: > lgtm I don't know the answer to your question ...
3 years, 8 months ago (2017-04-13 16:48:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815173002/1
3 years, 8 months ago (2017-04-13 16:49:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 18:49:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86670b9ee927163fffe528e93d81...

Powered by Google App Engine
This is Rietveld 408576698