Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2815153002: Only log the job controller count when it's hitting boundaries for the first time (Closed)

Created:
3 years, 8 months ago by Zhongyi Shi
Modified:
3 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only log the job controller count when it's hitting boundaries for the first time so that when normal job controllers are getting created, and deleted, which introduces a zigzag pattern in job controller count, we will not log the same user multiple times. BUG=704988 Review-Url: https://codereview.chromium.org/2815153002 Cr-Commit-Position: refs/heads/master@{#464193} Committed: https://chromium.googlesource.com/chromium/src/+/a95a63804d48bfb9acfcaabc124504419dcd3668

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M net/http/http_stream_factory_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Zhongyi Shi
Thanks for the great suggestion! PTAL!
3 years, 8 months ago (2017-04-12 20:50:19 UTC) #5
Ryan Hamilton
lgtm https://codereview.chromium.org/2815153002/diff/1/net/http/http_stream_factory_impl.cc File net/http/http_stream_factory_impl.cc (right): https://codereview.chromium.org/2815153002/diff/1/net/http/http_stream_factory_impl.cc#newcode366 net/http/http_stream_factory_impl.cc:366: return; nit: now that the predicate is more ...
3 years, 8 months ago (2017-04-12 21:05:53 UTC) #6
Zhongyi Shi
Landing now, thanks! https://codereview.chromium.org/2815153002/diff/1/net/http/http_stream_factory_impl.cc File net/http/http_stream_factory_impl.cc (right): https://codereview.chromium.org/2815153002/diff/1/net/http/http_stream_factory_impl.cc#newcode366 net/http/http_stream_factory_impl.cc:366: return; On 2017/04/12 21:05:53, Ryan Hamilton ...
3 years, 8 months ago (2017-04-12 21:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815153002/20001
3 years, 8 months ago (2017-04-12 21:18:57 UTC) #10
xunjieli
On 2017/04/12 21:18:57, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 8 months ago (2017-04-12 21:22:49 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 23:06:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a95a63804d48bfb9acfcaabc1245...

Powered by Google App Engine
This is Rietveld 408576698