MD Settings: Fix alignment issues after adding left/right padding to md-select.

MD Settings: Fix alignment issues after adding left/right padding to md-select.

Also restoring "visual" default width of 200px.

BUG=710785, 710802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815113002
Cr-Commit-Position: refs/heads/master@{#464144}
Committed: https://chromium.googlesource.com/chromium/src/+/0d4361cef2ed487f1a627ccd5a4047c8cbd899e8

[dpapad, 2017-04-12 18:16:31]

Description was changed from

==========
MD Settings: Fix alignment issues after adding left/right padding to md-select.

BUG=710785,710802
==========

to

==========
MD Settings: Fix alignment issues after adding left/right padding to md-select.

BUG=710785,710802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-12 18:17:35]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-12 18:30:51]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-04-12 18:30:53]

http://imgur.com/a/h71v8

https://codereview.chromium.org/2815113002/diff/1/ui/webui/resources/html/md_...
File ui/webui/resources/html/md_select_css.html (right):

https://codereview.chromium.org/2815113002/diff/1/ui/webui/resources/html/md_...
ui/webui/resources/html/md_select_css.html:32: width: var(--md-select-width,
200px);
I think we should change 200px to 224px.

Previously the select was 200px (both visible part and click target).

Now our select's click target is still 200px, but the visible part of the select
is smaller because of the padding. If we want to preserve that the "visible part
of select should be 200px" we need to increase that value.

[Dan Beam, 2017-04-12 18:33:21]

lgtm

https://codereview.chromium.org/2815113002/diff/1/ui/webui/resources/html/md_...
File ui/webui/resources/html/md_select_css.html (right):

https://codereview.chromium.org/2815113002/diff/1/ui/webui/resources/html/md_...
ui/webui/resources/html/md_select_css.html:32: width: var(--md-select-width,
200px);
On 2017/04/12 18:30:52, dpapad wrote:
> I think we should change 200px to 224px.
> 
> Previously the select was 200px (both visible part and click target).
> 
> Now our select's click target is still 200px, but the visible part of the
select
> is smaller because of the padding. If we want to preserve that the "visible
part
> of select should be 200px" we need to increase that value.

width: calc(var(--md-select-width, 200px) + 2 * var(--md-side-padding));

[dpapad, 2017-04-12 19:18:02]

Description was changed from

==========
MD Settings: Fix alignment issues after adding left/right padding to md-select.

BUG=710785,710802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix alignment issues after adding left/right padding to md-select.

Also restoring "visual" default width of 200px.

BUG=710785,710802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-12 19:27:47]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-04-12 19:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2815113002/#ps20001
(title: "Specify width")

[commit-bot: I haz the power, 2017-04-12 19:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-12 20:48:27]

https://codereview.chromium.org/2815113002/diff/1/ui/webui/resources/html/md_...
File ui/webui/resources/html/md_select_css.html (right):

https://codereview.chromium.org/2815113002/diff/1/ui/webui/resources/html/md_...
ui/webui/resources/html/md_select_css.html:32: width: var(--md-select-width,
200px);
> width: calc(var(--md-select-width, 200px) + 2 * var(--md-side-padding));

Done.

[commit-bot: I haz the power, 2017-04-12 20:49:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492025267927480,
"parent_rev": "49ae49cf55212633677d6aab382efc0044a58114", "commit_rev":
"0d4361cef2ed487f1a627ccd5a4047c8cbd899e8"}

[commit-bot: I haz the power, 2017-04-12 20:50:45]

Description was changed from

==========
MD Settings: Fix alignment issues after adding left/right padding to md-select.

Also restoring "visual" default width of 200px.

BUG=710785,710802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix alignment issues after adding left/right padding to md-select.

Also restoring "visual" default width of 200px.

BUG=710785,710802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815113002
Cr-Commit-Position: refs/heads/master@{#464144}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d4361cef2ed487f1a627ccd5a40...
==========

[commit-bot: I haz the power, 2017-04-12 20:50:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d4361cef2ed487f1a627ccd5a40...