Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py.

Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py.

Since the Blink rename, enum entry names now use the kCamelCase naming
convention instead of SHOUTY_CASE. This doesn't match well with Java
naming conventions and Java constants created by java_cpp_enum.py look
out of place with the rest of the Java codebase.

This CL modifies java_cpp_enum.py so that C++ enum naming conventions
don't leak into the Java side, specifically translating kCamelCase and
CamelCase enum entries to SHOUTY_CASE.

BUG=710335
Review-Url: https://codereview.chromium.org/2815103004
Cr-Commit-Position: refs/heads/master@{#464661}
Committed: https://chromium.googlesource.com/chromium/src/+/23b8f65ce75fc2ff04a28cb5a940861c134e0797

[estevenson, 2017-04-13 11:32:19]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 11:32:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2017-04-13 11:39:22]

Description was changed from

==========
Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py.

After the Blink rename enums now follow kCamelCase naming. This doesn't
match other Java code naming conventions, so this CL modifies
java_cpp_enum.py to convert C++ enum names to appropriate Java constant
names.

This CL changes regular CamelCase enums to be converted to
SHOUTY_CASE as well.

BUG=710335
==========

to

==========
Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py.

Since the Blink rename, enum entry names now use the kCamelCase naming
convention instead of SHOUTY_CASE. This doesn't match well with Java
naming conventions and Java constants created by java_cpp_enum.py look
out of place with the rest of the Java codebase.

This CL modifies java_cpp_enum.py so that C++ enum naming conventions
don't leak into the Java side, specifically translating kCamelCase and
CamelCase enum entries to SHOUTY_CASE.

BUG=710335
==========

[commit-bot: I haz the power, 2017-04-13 11:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 11:39:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estevenson, 2017-04-13 12:07:31]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2017-04-13 12:12:39]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-04-13 12:12:40]

ptal Andrew!

[commit-bot: I haz the power, 2017-04-13 13:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 13:39:25]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-04-13 13:52:35]

lgtm. Glad there's tests :)

https://codereview.chromium.org/2815103004/diff/40001/build/android/gyp/java_...
File build/android/gyp/java_cpp_enum.py (right):

https://codereview.chromium.org/2815103004/diff/40001/build/android/gyp/java_...
build/android/gyp/java_cpp_enum.py:119: if isinstance(v, basestring):
nit: can you just mention in a comment here when things are a string vs. not.

https://codereview.chromium.org/2815103004/diff/40001/build/android/gyp/java_...
build/android/gyp/java_cpp_enum.py:120: ret[normal_keys[k]] = reduce(
nit: this is pretty hard to mentally grok (at least for me). Probably would be
easier to follow if written out as a loop.

[estevenson, 2017-04-13 14:11:13]

estevenson@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dtrainor@chromium.org, torne@chromium.org

[estevenson, 2017-04-13 14:11:14]

torne@chromium.org: Please review changes in //android_webview

dalecurtis@chromium.org: Please review changes in //media

dtrainor@chromium.org: Please review changes in //chrome and //content

https://codereview.chromium.org/2815103004/diff/40001/build/android/gyp/java_...
File build/android/gyp/java_cpp_enum.py (right):

https://codereview.chromium.org/2815103004/diff/40001/build/android/gyp/java_...
build/android/gyp/java_cpp_enum.py:119: if isinstance(v, basestring):
On 2017/04/13 13:52:34, agrieve wrote:
> nit: can you just mention in a comment here when things are a string vs. not.

Done.

https://codereview.chromium.org/2815103004/diff/40001/build/android/gyp/java_...
build/android/gyp/java_cpp_enum.py:120: ret[normal_keys[k]] = reduce(
On 2017/04/13 13:52:34, agrieve wrote:
> nit: this is pretty hard to mentally grok (at least for me). Probably would be
> easier to follow if written out as a loop.

Done.

[Torne, 2017-04-13 16:05:56]

android_webview LGTM

[DaleCurtis, 2017-04-13 20:48:49]

media/ lgtm

[David Trainor- moved to gerrit, 2017-04-14 00:05:57]

chrome/ lgtm and content/ lgtm

[estevenson, 2017-04-14 00:52:51]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-04-14 00:52:52]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2815103004/#ps60001
(title: "Address agrieve@ comments")

[commit-bot: I haz the power, 2017-04-14 00:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 02:40:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492131171625720,
"parent_rev": "e93a3f46d4f8d8d0bfedc9978b2e55f29a023030", "commit_rev":
"23b8f65ce75fc2ff04a28cb5a940861c134e0797"}

[commit-bot: I haz the power, 2017-04-14 02:41:10]

Description was changed from

==========
Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py.

Since the Blink rename, enum entry names now use the kCamelCase naming
convention instead of SHOUTY_CASE. This doesn't match well with Java
naming conventions and Java constants created by java_cpp_enum.py look
out of place with the rest of the Java codebase.

This CL modifies java_cpp_enum.py so that C++ enum naming conventions
don't leak into the Java side, specifically translating kCamelCase and
CamelCase enum entries to SHOUTY_CASE.

BUG=710335
==========

to

==========
Android: convert kEnumName to ENUM_NAME in java_cpp_enum.py.

Since the Blink rename, enum entry names now use the kCamelCase naming
convention instead of SHOUTY_CASE. This doesn't match well with Java
naming conventions and Java constants created by java_cpp_enum.py look
out of place with the rest of the Java codebase.

This CL modifies java_cpp_enum.py so that C++ enum naming conventions
don't leak into the Java side, specifically translating kCamelCase and
CamelCase enum entries to SHOUTY_CASE.

BUG=710335

Review-Url: https://codereview.chromium.org/2815103004
Cr-Commit-Position: refs/heads/master@{#464661}
Committed:
https://chromium.googlesource.com/chromium/src/+/23b8f65ce75fc2ff04a28cb5a940...
==========

[commit-bot: I haz the power, 2017-04-14 02:41:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/23b8f65ce75fc2ff04a28cb5a940...