predictors: Enable origin learning with a flag.

predictors: Enable origin learning with a flag.

BUG=699080
Review-Url: https://codereview.chromium.org/2815103002
Cr-Commit-Position: refs/heads/master@{#464365}
Committed: https://chromium.googlesource.com/chromium/src/+/a457ee38bf4433cabb4c27c66f545cf5a0b7bc8e

[Benoit L, 2017-04-13 08:45:39]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 08:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benoit L, 2017-04-13 08:48:25]

lizeb@chromium.org changed reviewers:
+ alexilin@chromium.org

[alexilin, 2017-04-13 09:01:22]

lgtm, thanks!

One question about renaming config parameter name:
Do you want to have two different flags for origin learning and prediction in
the future?

https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_common_unittest.cc (right):

https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_common_unittest.cc:165:
TEST_F(ResourcePrefetchCommonTest, EnableOriginPrediction) {
nit:
s/EnableOriginPrediction/EnableOriginLearning

https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_common_unittest.cc:174:
EXPECT_TRUE(config.IsLearningEnabled());
nit:
Change this line with `TestIsPrefetchLearning(config);` just to be consistent

[Benoit L, 2017-04-13 09:15:40]

Thanks!

Yes, if we do an experiment, we will need to separate learning from prefetching.

On 2017/04/13 09:01:22, alexilin wrote:
> lgtm, thanks!
> 
> One question about renaming config parameter name:
> Do you want to have two different flags for origin learning and prediction in
> the future?
> 
>
https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
> File chrome/browser/predictors/resource_prefetch_common_unittest.cc (right):
> 
>
https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
> chrome/browser/predictors/resource_prefetch_common_unittest.cc:165:
> TEST_F(ResourcePrefetchCommonTest, EnableOriginPrediction) {
> nit:
> s/EnableOriginPrediction/EnableOriginLearning
> 
>
https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
> chrome/browser/predictors/resource_prefetch_common_unittest.cc:174:
> EXPECT_TRUE(config.IsLearningEnabled());
> nit:
> Change this line with `TestIsPrefetchLearning(config);` just to be consistent

[Benoit L, 2017-04-13 09:15:47]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2017-04-13 09:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexilin@chromium.org
Link to the patchset: https://codereview.chromium.org/2815103002/#ps40001
(title: ".")

[Benoit L, 2017-04-13 09:15:52]

https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_common_unittest.cc (right):

https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_common_unittest.cc:165:
TEST_F(ResourcePrefetchCommonTest, EnableOriginPrediction) {
On 2017/04/13 09:01:21, alexilin wrote:
> nit:
> s/EnableOriginPrediction/EnableOriginLearning

Done.

https://codereview.chromium.org/2815103002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_common_unittest.cc:174:
EXPECT_TRUE(config.IsLearningEnabled());
On 2017/04/13 09:01:21, alexilin wrote:
> nit:
> Change this line with `TestIsPrefetchLearning(config);` just to be consistent

Done.

[commit-bot: I haz the power, 2017-04-13 09:16:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 10:06:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492074947120270,
"parent_rev": "ea6683f28f572747a4cf77eed7748f9044061e34", "commit_rev":
"a457ee38bf4433cabb4c27c66f545cf5a0b7bc8e"}

[commit-bot: I haz the power, 2017-04-13 10:07:53]

Description was changed from

==========
predictors: Enable origin learning with a flag.

BUG=699080
==========

to

==========
predictors: Enable origin learning with a flag.

BUG=699080

Review-Url: https://codereview.chromium.org/2815103002
Cr-Commit-Position: refs/heads/master@{#464365}
Committed:
https://chromium.googlesource.com/chromium/src/+/a457ee38bf4433cabb4c27c66f54...
==========

[commit-bot: I haz the power, 2017-04-13 10:07:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a457ee38bf4433cabb4c27c66f54...