Correctly recognize non-constant enum children (issue 29306)

pkg/analyzer/lib/src/dart/element/element.dart

Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index f5b2df67ad4136ad981f5d64e9dde6765e2ffdcc..7224413a7c40c45d66885a0f15af9ff624727525 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -4236,8 +4236,9 @@ class FieldElementImpl extends PropertyInducingElementImpl
   }
 
   @override
-  bool get isEnumConstant =>
-      enclosingElement != null ? enclosingElement.isEnum : false;
+  bool get isEnumConstant => enclosingElement != null
+      ? enclosingElement.isEnum && !isSynthetic
+      : false;

[scheglov, 2017/04/12 16:00:01]

I think this could be "enclosingElement != null && enclosingElement.isEnum &&
!isSynthetic;"

[Brian Wilkerson, 2017/04/12 16:43:01]

Done

 
   @override
   bool get isStatic {