Correctly recognize non-constant enum children (issue 29306)

pkg/analyzer/lib/src/dart/element/element.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.dart.element.element;
 
 import 'dart:collection';
 import 'dart:math' show min;
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 4218 matching lines @@
 
   /**
    * Set whether this field is explicitly marked as being covariant.
    */
   void set isCovariant(bool isCovariant) {
     _assertNotResynthesized(_unlinkedVariable);
     setModifier(Modifier.COVARIANT, isCovariant);
   }
 
   @override
-  bool get isEnumConstant =>
-      enclosingElement != null ? enclosingElement.isEnum : false;
+  bool get isEnumConstant => enclosingElement != null
+      ? enclosingElement.isEnum && !isSynthetic
+      : false;

[scheglov, 2017/04/12 16:00:01]

I think this could be "enclosingElement != null && enclosingElement.isEnum &&
!isSynthetic;"

[Brian Wilkerson, 2017/04/12 16:43:01]

Done

 
   @override
   bool get isStatic {
     if (_unlinkedVariable != null) {
       return _unlinkedVariable.isStatic;
     }
     return hasModifier(Modifier.STATIC);
   }
 
   /**
@@ skipping 4854 matching lines @@
 
   @override
   void visitElement(Element element) {
     int offset = element.nameOffset;
     if (offset != -1) {
       map[offset] = element;
     }
     super.visitElement(element);
   }
 }