Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2815093002: Correctly recognize non-constant enum children (issue 29306) (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correctly recognize non-constant enum children (issue 29306) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dd150dd348ada4191c35c3bf1a3501aab6ff4a3e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +3 lines, -2 lines 2 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-12 15:40:09 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2815093002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2815093002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode4241 pkg/analyzer/lib/src/dart/element/element.dart:4241: : false; I think this could be "enclosingElement ...
3 years, 8 months ago (2017-04-12 16:00:01 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2815093002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2815093002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode4241 pkg/analyzer/lib/src/dart/element/element.dart:4241: : false; Done
3 years, 8 months ago (2017-04-12 16:43:01 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-12 16:43:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dd150dd348ada4191c35c3bf1a3501aab6ff4a3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698