Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2815083002: Android: Fix net/test AndroidManifest (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix net/test AndroidManifest There is no android:action in intent-filter: https://developer.android.com/guide/topics/manifest/intent-filter-element.html This causes errors in Android Studio when including this AndroidManifest. BUG=620034 Review-Url: https://codereview.chromium.org/2815083002 Cr-Commit-Position: refs/heads/master@{#464387} Committed: https://chromium.googlesource.com/chromium/src/+/df07380a347b8a706bb28afb97f0295282bf683b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M net/test/android/javatests/AndroidManifest.xml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Peter Wen
Hi Pawel, PTAL. Android Studio is happy with this change aligning with https://cs.chromium.org/chromium/src/chrome/test/android/chrome_public_test_support/AndroidManifest.xml
3 years, 8 months ago (2017-04-12 14:58:59 UTC) #4
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-04-13 11:00:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815083002/1
3 years, 8 months ago (2017-04-13 12:52:41 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 13:01:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df07380a347b8a706bb28afb97f0...

Powered by Google App Engine
This is Rietveld 408576698