Revert of Remove CompositorObserver::OnCompositingEnded()

Revert of Remove CompositorObserver::OnCompositingEnded() (patchset #5 id:80001 of https://codereview.chromium.org/2776973004/ )

Reason for revert:
Cause LayerWithRealCompositorTest.ReportMetrics to 
be flaky on Windows.

We don't need this change anyway now that 
MojoCompositorFrameSinkClient::WillDrawSurface() is 
removed.

Original issue's description:
> Remove CompositorObserver::OnCompositingEnded()
> 
> OnCompistingEnded() is only used in tests. By replacing usages of
> OnCompositingEnded() with OnCompositingStarted(), we are able to remove
> the call to OnCompositingEnded() in
> ui::Compositor::DidReceiveCompositorFrameAck() without making the tests less
> effective.
> 
> This is the first step in simplifying CompositorFrameAcks.
> 
> BUG=671202
> 
> Review-Url: https://codereview.chromium.org/2776973004
> Cr-Commit-Position: refs/heads/master@{#460409}
> Committed: https://chromium.googlesource.com/chromium/src/+/ce75f9388f73820bc5bb31401bcc75520f467a3f

TBR=fsamuel@chromium.org,danakj@chromium.org,varkha@chromium.org,sky@chromium.org,asvitkine@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671202, 709080
Review-Url: https://codereview.chromium.org/2815073002
Cr-Commit-Position: refs/heads/master@{#464468}
Committed: https://chromium.googlesource.com/chromium/src/+/b14cc10ccf83caad627156403239fc6758c2dbbb

[Alex Z., 2017-04-12 12:27:01]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-12 12:27:02]

Created Revert of Remove CompositorObserver::OnCompositingEnded()

[commit-bot: I haz the power, 2017-04-12 12:27:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 12:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 12:27:19]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Alex Z., 2017-04-12 12:28:14]

Description was changed from

==========
Revert of Remove CompositorObserver::OnCompositingEnded() (patchset #5 id:80001
of https://codereview.chromium.org/2776973004/ )

Reason for revert:
Cause LayerWithRealCompositorTest.ReportMetrics to 
be flaky on Windows.

We don't need this change anyway now that 
MojoCompositorFrameSinkClient::WillDrawSurface() is 
removed.

Original issue's description:
> Remove CompositorObserver::OnCompositingEnded()
> 
> OnCompistingEnded() is only used in tests. By replacing usages of
> OnCompositingEnded() with OnCompositingStarted(), we are able to remove
> the call to OnCompositingEnded() in
> ui::Compositor::DidReceiveCompositorFrameAck() without making the tests less
> effective.
> 
> This is the first step in simplifying CompositorFrameAcks.
> 
> BUG=671202
> 
> Review-Url: https://codereview.chromium.org/2776973004
> Cr-Commit-Position: refs/heads/master@{#460409}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ce75f9388f73820bc5bb31401bcc...

TBR=fsamuel@chromium.org,danakj@chromium.org,varkha@chromium.org,sky@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671202
==========

to

==========
Revert of Remove CompositorObserver::OnCompositingEnded() (patchset #5 id:80001
of https://codereview.chromium.org/2776973004/ )

Reason for revert:
Cause LayerWithRealCompositorTest.ReportMetrics to 
be flaky on Windows.

We don't need this change anyway now that 
MojoCompositorFrameSinkClient::WillDrawSurface() is 
removed.

Original issue's description:
> Remove CompositorObserver::OnCompositingEnded()
> 
> OnCompistingEnded() is only used in tests. By replacing usages of
> OnCompositingEnded() with OnCompositingStarted(), we are able to remove
> the call to OnCompositingEnded() in
> ui::Compositor::DidReceiveCompositorFrameAck() without making the tests less
> effective.
> 
> This is the first step in simplifying CompositorFrameAcks.
> 
> BUG=671202
> 
> Review-Url: https://codereview.chromium.org/2776973004
> Cr-Commit-Position: refs/heads/master@{#460409}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ce75f9388f73820bc5bb31401bcc...

TBR=fsamuel@chromium.org,danakj@chromium.org,varkha@chromium.org,sky@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671202, 709080
==========

[Fady Samuel, 2017-04-13 03:04:34]

lgtm

[Fady Samuel, 2017-04-13 03:04:40]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:09:32]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alex Z., 2017-04-13 13:07:59]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-13 13:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2815073002/#ps230001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-13 13:08:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 13:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 13:21:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alex Z., 2017-04-13 13:31:55]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-13 13:31:55]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2815073002/#ps250001
(title: "Fix Compiling Error")

[commit-bot: I haz the power, 2017-04-13 13:32:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 13:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 13:42:20]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alex Z., 2017-04-13 14:26:44]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 14:26:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 14:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:45:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alex Z., 2017-04-13 14:49:49]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 14:50:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 15:36:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 15:36:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alex Z., 2017-04-13 15:58:54]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 15:59:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 17:14:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 17:14:19]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-04-13 17:52:47]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-13 17:52:47]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2815073002/#ps310001
(title: "Fix CompositorObservers test")

[commit-bot: I haz the power, 2017-04-13 17:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:06:46]

CQ is committing da patch.

Bot data: {"patchset_id": 310001, "attempt_start_ts": 1492105967136560,
"parent_rev": "a618ae85f99de9dfcd3596d40e247b92b52eb745", "commit_rev":
"b14cc10ccf83caad627156403239fc6758c2dbbb"}

[commit-bot: I haz the power, 2017-04-13 18:07:45]

Description was changed from

==========
Revert of Remove CompositorObserver::OnCompositingEnded() (patchset #5 id:80001
of https://codereview.chromium.org/2776973004/ )

Reason for revert:
Cause LayerWithRealCompositorTest.ReportMetrics to 
be flaky on Windows.

We don't need this change anyway now that 
MojoCompositorFrameSinkClient::WillDrawSurface() is 
removed.

Original issue's description:
> Remove CompositorObserver::OnCompositingEnded()
> 
> OnCompistingEnded() is only used in tests. By replacing usages of
> OnCompositingEnded() with OnCompositingStarted(), we are able to remove
> the call to OnCompositingEnded() in
> ui::Compositor::DidReceiveCompositorFrameAck() without making the tests less
> effective.
> 
> This is the first step in simplifying CompositorFrameAcks.
> 
> BUG=671202
> 
> Review-Url: https://codereview.chromium.org/2776973004
> Cr-Commit-Position: refs/heads/master@{#460409}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ce75f9388f73820bc5bb31401bcc...

TBR=fsamuel@chromium.org,danakj@chromium.org,varkha@chromium.org,sky@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671202, 709080
==========

to

==========
Revert of Remove CompositorObserver::OnCompositingEnded() (patchset #5 id:80001
of https://codereview.chromium.org/2776973004/ )

Reason for revert:
Cause LayerWithRealCompositorTest.ReportMetrics to 
be flaky on Windows.

We don't need this change anyway now that 
MojoCompositorFrameSinkClient::WillDrawSurface() is 
removed.

Original issue's description:
> Remove CompositorObserver::OnCompositingEnded()
> 
> OnCompistingEnded() is only used in tests. By replacing usages of
> OnCompositingEnded() with OnCompositingStarted(), we are able to remove
> the call to OnCompositingEnded() in
> ui::Compositor::DidReceiveCompositorFrameAck() without making the tests less
> effective.
> 
> This is the first step in simplifying CompositorFrameAcks.
> 
> BUG=671202
> 
> Review-Url: https://codereview.chromium.org/2776973004
> Cr-Commit-Position: refs/heads/master@{#460409}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ce75f9388f73820bc5bb31401bcc...

TBR=fsamuel@chromium.org,danakj@chromium.org,varkha@chromium.org,sky@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671202, 709080

Review-Url: https://codereview.chromium.org/2815073002
Cr-Commit-Position: refs/heads/master@{#464468}
Committed:
https://chromium.googlesource.com/chromium/src/+/b14cc10ccf83caad627156403239...
==========

[commit-bot: I haz the power, 2017-04-13 18:07:46]

Committed patchset #6 (id:310001) as
https://chromium.googlesource.com/chromium/src/+/b14cc10ccf83caad627156403239...