Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2815063002: Rename variable, class, function, etc from libarchive to minizip. (Closed)

Created:
3 years, 8 months ago by takise
Modified:
3 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, yawano
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename variable, class, function, etc from libarchive to minizip. This CL renames all the identifiers with libarchive to minizip. Note that we are going to change the filenames in another CL. BUG=607078 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815063002 Cr-Commit-Position: refs/heads/master@{#463952} Committed: https://chromium.googlesource.com/chromium/src/+/1f46c3f8167ab959fa80fa2e8b1d9a56e5e8bd46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -98 lines) Patch
M ui/file_manager/zip_archiver/cpp/compressor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/compressor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/cpp/compressor_archive_libarchive.h View 5 chunks +9 lines, -9 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/compressor_archive_libarchive.cc View 6 chunks +25 lines, -25 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/compressor_io_javascript_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/cpp/module.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume_archive_libarchive.h View 7 chunks +21 lines, -21 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume_archive_libarchive.cc View 14 chunks +22 lines, -22 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume_reader_javascript_stream.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/zip_archiver/js/app.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/js/compressor.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/zip_archiver/js/decompressor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
takise
PTAL. Thanks!
3 years, 8 months ago (2017-04-12 07:35:09 UTC) #4
mtomasz
lgtm, thanks!
3 years, 8 months ago (2017-04-12 07:38:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815063002/1
3 years, 8 months ago (2017-04-12 07:51:25 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 07:57:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f46c3f8167ab959fa80fa2e8b1d...

Powered by Google App Engine
This is Rietveld 408576698