Split initial methods of left/right/top/bottom on ComputedStyle.

Split initial methods of left/right/top/bottom on ComputedStyle.

Currently the left, right, top and bottom share the same method for
the initial value: initialOffset(). This makes it difficult to generate
because the generator will generate four copies of initialOffset(),
causing a name conflict.

This patch splits the initialOffset() method into four separate methods,
one for each property.

Diff of generated files:
https://gist.github.com/darrnshn/88a94abf4e37e26b7fdcc4126beb11fa/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2815033002
Cr-Commit-Position: refs/heads/master@{#464313}
Committed: https://chromium.googlesource.com/chromium/src/+/68c508188787079d0400260ee4dff6ef6814c40c

[shend, 2017-04-12 04:09:25]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-04-12 04:09:25]

Hi Naina, PTAL :)

[nainar, 2017-04-12 05:21:28]

lgtm

[shend, 2017-04-12 05:40:40]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-04-12 05:40:40]

Hi Alan, PTAL

[alancutter (OOO until 2018), 2017-04-12 05:43:27]

lgtm

How was 'initial: "InitialOffset"' used anyway? What's the generated diff here?

[shend, 2017-04-12 05:51:17]

Description was changed from

==========
Split initial methods of left/right/top/bottom on ComputedStyle.

Currently the left, right, top and bottom share the same method for
the initial value: initialOffset(). This makes it difficult to generate
because the generator will generate four copies of initialOffset(),
causing a name conflict.

This patch splits the initialOffset() method into four separate methods,
one for each property.

BUG=628043
==========

to

==========
Split initial methods of left/right/top/bottom on ComputedStyle.

Currently the left, right, top and bottom share the same method for
the initial value: initialOffset(). This makes it difficult to generate
because the generator will generate four copies of initialOffset(),
causing a name conflict.

This patch splits the initialOffset() method into four separate methods,
one for each property.

Diff of generated files:
https://gist.github.com/darrnshn/88a94abf4e37e26b7fdcc4126beb11fa/revisions

BUG=628043
==========

[shend, 2017-04-12 05:51:37]

On 2017/04/12 at 05:43:27, alancutter wrote:
> lgtm
> 
> How was 'initial: "InitialOffset"' used anyway? What's the generated diff
here?

It was used in StyleBuilder. Attached generated diff.

[shend, 2017-04-12 05:55:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 05:55:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 07:42:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 07:42:18]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-13 05:08:16]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 05:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:12:15]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-13 05:23:43]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:24:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:38:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492061023805400, "parent_rev":
"51e87859e8337f4cf3f9aa995884de4b786e7279", "commit_rev":
"68c508188787079d0400260ee4dff6ef6814c40c"}

[commit-bot: I haz the power, 2017-04-13 05:39:42]

Description was changed from

==========
Split initial methods of left/right/top/bottom on ComputedStyle.

Currently the left, right, top and bottom share the same method for
the initial value: initialOffset(). This makes it difficult to generate
because the generator will generate four copies of initialOffset(),
causing a name conflict.

This patch splits the initialOffset() method into four separate methods,
one for each property.

Diff of generated files:
https://gist.github.com/darrnshn/88a94abf4e37e26b7fdcc4126beb11fa/revisions

BUG=628043
==========

to

==========
Split initial methods of left/right/top/bottom on ComputedStyle.

Currently the left, right, top and bottom share the same method for
the initial value: initialOffset(). This makes it difficult to generate
because the generator will generate four copies of initialOffset(),
causing a name conflict.

This patch splits the initialOffset() method into four separate methods,
one for each property.

Diff of generated files:
https://gist.github.com/darrnshn/88a94abf4e37e26b7fdcc4126beb11fa/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2815033002
Cr-Commit-Position: refs/heads/master@{#464313}
Committed:
https://chromium.googlesource.com/chromium/src/+/68c508188787079d0400260ee4df...
==========

[commit-bot: I haz the power, 2017-04-13 05:39:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68c508188787079d0400260ee4df...