Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2815023004: InProcessCommandBuffer::OnWaitSyncTokenCompleted should not enqueue a new task. (Closed)

Created:
3 years, 8 months ago by mfomitchev
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Fady Samuel
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

InProcessCommandBuffer::OnWaitSyncTokenCompleted should not enqueue a new task. Instead it should simply schedule the service to process tasks again. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2815023004 Cr-Commit-Position: refs/heads/master@{#464188} Committed: https://chromium.googlesource.com/chromium/src/+/995b74dc39fedb4f3cdeb67bb32ad3d26ea175ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/ipc/in_process_command_buffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mfomitchev
3 years, 8 months ago (2017-04-12 19:58:42 UTC) #3
piman
lgtm
3 years, 8 months ago (2017-04-12 19:59:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815023004/1
3 years, 8 months ago (2017-04-12 20:03:04 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 22:56:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/995b74dc39fedb4f3cdeb67bb32a...

Powered by Google App Engine
This is Rietveld 408576698