Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2815023003:
Add Most Visited tiles to ContentSuggestions (Closed)
|
Created:
3 years, 8 months ago by gambard Modified:
3 years, 7 months ago Reviewers:
lpromero CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Most Visited tiles to ContentSuggestions
This CL creates and add the Most Visited tiles to the ContentSuggestions.
BUG=707754, 708491, 713183
Review-Url: https://codereview.chromium.org/2815023003
Cr-Commit-Position: refs/heads/master@{#470264}
Committed: https://chromium.googlesource.com/chromium/src/+/29067c254b36f05d476335066744e3f6782c7e98
Patch Set 1 #
Total comments: 6
Patch Set 2 : Address comments #Patch Set 3 : Fix tests #Messages
Total messages: 19 (11 generated)
gambard@chromium.org changed reviewers: + lpromero@chromium.org
PTAL.
https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:313: // TODO(crbug.com/707754): Add the most visited item. Remove. https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:323: (ContentSuggestionsMostVisitedItem*)[model itemAtIndexPath:indexPath]; base::mac::ObjCCast<ContentSuggestionsMostVisitedItem>? https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:326: [self.collectionViewController.collectionViewLayout invalidateLayout]; I don't think this belongs in this method. If necessary it should be done at the callsite.
Description was changed from ========== Add Most Visited tiles to ContentSuggestions This CL creates and add the Most Visited tiles to the ContentSuggestions. BUG=707754 ========== to ========== Add Most Visited tiles to ContentSuggestions This CL creates and add the Most Visited tiles to the ContentSuggestions. BUG=707754, 708491, 713183 ==========
Thanks, PTAL. https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:313: // TODO(crbug.com/707754): Add the most visited item. On 2017/05/05 15:08:25, lpromero wrote: > Remove. Done. https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:323: (ContentSuggestionsMostVisitedItem*)[model itemAtIndexPath:indexPath]; On 2017/05/05 15:08:25, lpromero wrote: > base::mac::ObjCCast<ContentSuggestionsMostVisitedItem>? Done. https://codereview.chromium.org/2815023003/diff/1/ios/chrome/browser/ui/conte... ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:326: [self.collectionViewController.collectionViewLayout invalidateLayout]; On 2017/05/05 15:08:24, lpromero wrote: > I don't think this belongs in this method. If necessary it should be done at the > callsite. Done.
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by lpromero@chromium.org
The CQ bit was checked by lpromero@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by gambard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lpromero@chromium.org Link to the patchset: https://codereview.chromium.org/2815023003/#ps40001 (title: "Fix tests")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494315753860300,
"parent_rev": "39cbe807824bdd083a40d66a9958b1fdfb5a8af8", "commit_rev":
"29067c254b36f05d476335066744e3f6782c7e98"}
Message was sent while issue was closed.
Description was changed from ========== Add Most Visited tiles to ContentSuggestions This CL creates and add the Most Visited tiles to the ContentSuggestions. BUG=707754, 708491, 713183 ========== to ========== Add Most Visited tiles to ContentSuggestions This CL creates and add the Most Visited tiles to the ContentSuggestions. BUG=707754, 708491, 713183 Review-Url: https://codereview.chromium.org/2815023003 Cr-Commit-Position: refs/heads/master@{#470264} Committed: https://chromium.googlesource.com/chromium/src/+/29067c254b36f05d476335066744... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/29067c254b36f05d476335066744... |
