[RemotePlayback] Use poster image as on lockscreen

[RemotePlayback] Use poster image as on lockscreen

This CL makes remote playback to use the poster image on Android
lockscreen. Also, we use the same logic for media notification to
exclude images that are too small.

BUG=710835
Review-Url: https://codereview.chromium.org/2814993005
Cr-Commit-Position: refs/heads/master@{#464189}
Committed: https://chromium.googlesource.com/chromium/src/+/1dab7e87de77216a39d54e8c9141d68f39f4f004

[Zhiqiang Zhang (Slow), 2017-04-12 16:24:41]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[Zhiqiang Zhang (Slow), 2017-04-12 16:24:41]

PTAL

[Zhiqiang Zhang (Slow), 2017-04-12 16:24:45]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:25:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:04:23]

Dry run: This issue passed the CQ dry run.

[whywhat, 2017-04-12 17:25:26]

lgtm

is this something you could add a test for?

https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
(right):

https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:87:
Bitmap poster = mMediaRouteController.getPoster();
nit: this code repeats exactly three times, can you extract it into a method?

[Zhiqiang Zhang (Slow), 2017-04-12 20:46:02]

On 2017/04/12 at 17:25:26, avayvod wrote:
> lgtm
> 
> is this something you could add a test for?

I prefer to leave it as the logic is too simple to test.

[Zhiqiang Zhang (Slow), 2017-04-12 20:46:11]

https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
(right):

https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:87:
Bitmap poster = mMediaRouteController.getPoster();
On 2017/04/12 at 17:25:26, whywhat wrote:
> nit: this code repeats exactly three times, can you extract it into a method?

Done.

[Zhiqiang Zhang (Slow), 2017-04-12 20:47:41]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-04-12 20:47:41]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2814993005/#ps20001
(title: "addressed nits")

[commit-bot: I haz the power, 2017-04-12 20:49:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:57:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492030061641500,
"parent_rev": "995b74dc39fedb4f3cdeb67bb32ad3d26ea175ee", "commit_rev":
"1dab7e87de77216a39d54e8c9141d68f39f4f004"}

[commit-bot: I haz the power, 2017-04-12 22:58:04]

Description was changed from

==========
[RemotePlayback] Use poster image as on lockscreen

This CL makes remote playback to use the poster image on Android
lockscreen. Also, we use the same logic for media notification to
exclude images that are too small.

BUG=710835
==========

to

==========
[RemotePlayback] Use poster image as on lockscreen

This CL makes remote playback to use the poster image on Android
lockscreen. Also, we use the same logic for media notification to
exclude images that are too small.

BUG=710835

Review-Url: https://codereview.chromium.org/2814993005
Cr-Commit-Position: refs/heads/master@{#464189}
Committed:
https://chromium.googlesource.com/chromium/src/+/1dab7e87de77216a39d54e8c9141...
==========

[commit-bot: I haz the power, 2017-04-12 22:58:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1dab7e87de77216a39d54e8c9141...