Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2814993005: [RemotePlayback] Use poster image as on lockscreen (Closed)

Created:
3 years, 8 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 8 months ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[RemotePlayback] Use poster image as on lockscreen This CL makes remote playback to use the poster image on Android lockscreen. Also, we use the same logic for media notification to exclude images that are too small. BUG=710835 Review-Url: https://codereview.chromium.org/2814993005 Cr-Commit-Position: refs/heads/master@{#464189} Committed: https://chromium.googlesource.com/chromium/src/+/1dab7e87de77216a39d54e8c9141d68f39f4f004

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java View 1 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Zhiqiang Zhang (Slow)
PTAL
3 years, 8 months ago (2017-04-12 16:24:41 UTC) #2
whywhat
lgtm is this something you could add a test for? https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java File chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java (right): https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java#newcode87 ...
3 years, 8 months ago (2017-04-12 17:25:26 UTC) #7
Zhiqiang Zhang (Slow)
On 2017/04/12 at 17:25:26, avayvod wrote: > lgtm > > is this something you could ...
3 years, 8 months ago (2017-04-12 20:46:02 UTC) #8
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java File chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java (right): https://codereview.chromium.org/2814993005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java#newcode87 chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java:87: Bitmap poster = mMediaRouteController.getPoster(); On 2017/04/12 at 17:25:26, whywhat ...
3 years, 8 months ago (2017-04-12 20:46:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814993005/20001
3 years, 8 months ago (2017-04-12 20:49:10 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 22:58:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1dab7e87de77216a39d54e8c9141...

Powered by Google App Engine
This is Rietveld 408576698