[devil] If possible, allow to enable root on user builds.

[devil] If possible, allow to enable root on user builds.

Generally it's not possible to "adb root" devices on user builds;
however some of them do.

With this change devil will first try to enable root on the device
(regardless of build type). Then, only if the command fails, we check
the device type to provide a more specific error message if
appropriate.

BUG=chromium:710479
Review-Url: https://codereview.chromium.org/2814993004
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/db507a3b77ae5ffb117fdb08e210aa829a68b347

[perezju, 2017-04-12 15:23:13]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org, ynovikov@chromium.org

[jbudorick, 2017-04-12 15:26:33]

lgtm

[perezju, 2017-04-12 15:29:30]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-04-12 15:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:53:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492010970773810, "parent_rev":
"f57871dac2cd1736f1fba0d8370a623bd51b4039", "commit_rev":
"db507a3b77ae5ffb117fdb08e210aa829a68b347"}

[commit-bot: I haz the power, 2017-04-12 15:53:40]

Description was changed from

==========
[devil] If possible, allow to enable root on user builds.

Generally it's not possible to "adb root" devices on user builds;
however some of them do.

With this change devil will first try to enable root on the device
(regardless of build type). Then, only if the command fails, we check
the device type to provide a more specific error message if
appropriate.

BUG=chromium:710479
==========

to

==========
[devil] If possible, allow to enable root on user builds.

Generally it's not possible to "adb root" devices on user builds;
however some of them do.

With this change devil will first try to enable root on the device
(regardless of build type). Then, only if the command fails, we check
the device type to provide a more specific error message if
appropriate.

BUG=chromium:710479

Review-Url: https://codereview.chromium.org/2814993004
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-04-12 15:53:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...