Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2814973003: Extract ClosedWorldRefiner implementation from ClosedWorldImpl to ClosedWorldBase (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract ClosedWorldRefiner implementation from ClosedWorldImpl to ClosedWorldBase - to make it reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/9cff58233ff62706d89bf94e9920cd08430f13da

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -108 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 8 chunks +85 lines, -74 lines 2 comments Download
M tests/compiler/dart2js/embedded_category_api_boundary_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-12 14:09:00 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2814973003/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2814973003/diff/1/pkg/compiler/lib/src/world.dart#newcode906 pkg/compiler/lib/src/world.dart:906: SideEffects getSideEffectsOfElement(Entity element) { getSideEffectsOfEntity?
3 years, 8 months ago (2017-04-12 18:07:18 UTC) #3
Johnni Winther
https://codereview.chromium.org/2814973003/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2814973003/diff/1/pkg/compiler/lib/src/world.dart#newcode906 pkg/compiler/lib/src/world.dart:906: SideEffects getSideEffectsOfElement(Entity element) { On 2017/04/12 18:07:18, Emily Fortuna ...
3 years, 8 months ago (2017-04-18 07:36:08 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-18 07:45:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9cff58233ff62706d89bf94e9920cd08430f13da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698