Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2814973003: Extract ClosedWorldRefiner implementation from ClosedWorldImpl to ClosedWorldBase (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 4b7329b56c28c1d0bef44d5e1cbbcf1b295ccd83..65620fda8e12fd01ac36f67a8728c26b339a147f 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -836,18 +836,14 @@ abstract class Compiler {
}
if (!REPORT_EXCESS_RESOLUTION) return;
var resolved = new Set.from(resolutionEnqueuer.processedEntities);
- for (Element e in codegenEnqueuer.processedEntities) {
+ for (MemberEntity e in codegenEnqueuer.processedEntities) {
resolved.remove(e);
}
- for (Element e in new Set.from(resolved)) {
- if (e.isClass ||
- e.isField ||
- e.isTypeVariable ||
- e.isTypedef ||
- identical(e.kind, ElementKind.ABSTRACT_FIELD)) {
+ for (MemberEntity e in new Set.from(resolved)) {
+ if (e.isField) {
resolved.remove(e);
}
- if (identical(e.kind, ElementKind.GENERATIVE_CONSTRUCTOR)) {
+ if (e.isConstructor && (e as ConstructorEntity).isGenerativeConstructor) {
resolved.remove(e);
}
if (backend.isTargetSpecificLibrary(e.library)) {
@@ -855,7 +851,7 @@ abstract class Compiler {
}
}
reporter.log('Excess resolution work: ${resolved.length}.');
- for (Element e in resolved) {
+ for (MemberEntity e in resolved) {
reporter.reportWarningMessage(e, MessageKind.GENERIC,
{'text': 'Warning: $e resolved but not compiled.'});
}

Powered by Google App Engine
This is Rietveld 408576698