Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: tracing/tracing/metrics/system_health/loading_metric.html

Issue 2814963004: Fix FirstContentfulPaint metric (Closed)
Patch Set: smoke test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/loading_metric.html
diff --git a/tracing/tracing/metrics/system_health/loading_metric.html b/tracing/tracing/metrics/system_health/loading_metric.html
index 2496e5b78da37477b220af80ea75890aa94eac0a..f6b855a570fab2e1d42fec162b8045e8043f401d 100644
--- a/tracing/tracing/metrics/system_health/loading_metric.html
+++ b/tracing/tracing/metrics/system_health/loading_metric.html
@@ -141,11 +141,11 @@ tr.exportTo('tr.metrics.sh', function() {
return snapshot;
}
- function findAllUserTimingEvents(rendererHelper, title) {
+ function findAllEvents(rendererHelper, category, title) {
var targetEvents = [];
for (var ev of rendererHelper.process.getDescendantEvents()) {
- if (!hasCategoryAndName(ev, 'blink.user_timing', title)) continue;
+ if (!hasCategoryAndName(ev, category, title)) continue;
targetEvents.push(ev);
}
@@ -182,9 +182,8 @@ tr.exportTo('tr.metrics.sh', function() {
}
function collectTimeToEvent(
- eventName, rendererHelper, navigationStartFinder) {
- var targetEvents =
- findAllUserTimingEvents(rendererHelper, eventName);
+ category, eventName, rendererHelper, navigationStartFinder) {
+ var targetEvents = findAllEvents(rendererHelper, category, eventName);
var samples = [];
for (var ev of targetEvents) {
if (rendererHelper.isTelemetryInternalEvent(ev)) continue;
@@ -429,9 +428,11 @@ tr.exportTo('tr.metrics.sh', function() {
var navigationStartFinder = new NavigationStartFinder(rendererHelper);
var firstContentfulPaintSamples = collectTimeToEvent(
- 'firstContentfulPaint', rendererHelper, navigationStartFinder);
+ 'loading', 'firstContentfulPaint',
+ rendererHelper, navigationStartFinder);
var onLoadSamples = collectTimeToEvent(
- 'loadEventStart', rendererHelper, navigationStartFinder);
+ 'blink.user_timing', 'loadEventStart',
+ rendererHelper, navigationStartFinder);
var {firstMeaningfulPaintSamples, firstMeaningfulPaintCpuTimeSamples,
firstInteractiveSamples} =
collectFirstMeaningfulPaintAndTimeToInteractiveForRenderer(

Powered by Google App Engine
This is Rietveld 408576698