Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

Issue 2814963004: Fix FirstContentfulPaint metric (Closed)
Patch Set: smoke test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/system_health/loading_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
diff --git a/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
index 2866ab7fec3ec8e0de4b75790f3a60aef2c5220d..245e3ced2eb7abd3f00e5e72ca056edd992e103e 100644
--- a/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
+++ b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
@@ -170,6 +170,9 @@ class TimelineBasedPageTestTest(page_test_test_case.PageTestTestCase):
self.assertIsNotNone(v_foo[0].page)
+ # TODO(ksakamoto): enable this in reference once the reference build of
+ # telemetry is updated.
+ @decorators.Disabled('reference')
@decorators.Disabled('chromeos')
def testFirstPaintMetricSmoke(self):
ps = self.CreateEmptyPageSet()
@@ -190,13 +193,9 @@ class TimelineBasedPageTestTest(page_test_test_case.PageTestTestCase):
'timeToFirstContentfulPaint_max')
self.assertEquals(len(v_ttfcp_max), 1)
self.assertIsNotNone(v_ttfcp_max[0].page)
- # TODO(kouhei): enable this once the reference build of telemetry is
- # updated.
- # self.assertGreater(v_ttfcp_max[0].value, 0)
+ self.assertGreater(v_ttfcp_max[0].value, 0)
v_ttfmp_max = results.FindAllPageSpecificValuesNamed(
'timeToFirstMeaningfulPaint_max')
self.assertEquals(len(v_ttfmp_max), 1)
- # TODO(ksakamoto): enable this once the reference build of telemetry is
- # updated.
- # self.assertIsNotNone(v_ttfmp_max[0].page)
+ self.assertIsNotNone(v_ttfmp_max[0].page)
« no previous file with comments | « no previous file | tracing/tracing/metrics/system_health/loading_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698