Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2814913002: Revert "Trigger linux_layout_tests_layout_ng for LayoutNG changes" (Closed)

Created:
3 years, 8 months ago by Gleb Lanbin
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Trigger linux_layout_tests_layout_ng for LayoutNG changes" This reverts commit ab81cf5d84d85f10c48b1c02dc9e8999df8928a3. Reason for revert: linux_layout_tests_layout_ng is blocking Chromium Presubmit Queue. Examples: - http://crrev.com/2810833003 - http://crrev.com/2805283003 - https://chromium-review.googlesource.com/c/474547/ linux_layout_tests_layout_ng bot is not designed to pass all LayoutTests. It should be configured as optional. BUG=706183 Review-Url: https://codereview.chromium.org/2814913002 Cr-Commit-Position: refs/heads/master@{#463844} Committed: https://chromium.googlesource.com/chromium/src/+/51ce668aebf388516f2349a0b55bc622c14e3f4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -35 lines) Patch
M third_party/WebKit/PRESUBMIT.py View 1 chunk +11 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Gleb Lanbin
3 years, 8 months ago (2017-04-11 22:21:32 UTC) #3
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-11 22:23:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814913002/1
3 years, 8 months ago (2017-04-11 23:46:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 23:57:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51ce668aebf388516f2349a0b55b...

Powered by Google App Engine
This is Rietveld 408576698