Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2814843008: VR: Destroy scene and scene manager on the thread they were created. (Closed)

Created:
3 years, 8 months ago by cjgrant
Modified:
3 years, 8 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Destroy scene and scene manager on the thread they were created. This fixes a crash when exiting VR. BUG=None Review-Url: https://codereview.chromium.org/2814843008 Cr-Commit-Position: refs/heads/master@{#464415} Committed: https://chromium.googlesource.com/chromium/src/+/b64525a610068d10330a05bc076791ba22f60c5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cjgrant
3 years, 8 months ago (2017-04-13 14:39:16 UTC) #2
mthiesse
lgtm
3 years, 8 months ago (2017-04-13 14:41:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814843008/1
3 years, 8 months ago (2017-04-13 14:41:59 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 15:30:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b64525a610068d10330a05bc0767...

Powered by Google App Engine
This is Rietveld 408576698