Specify the SDK version when running vcvarsall.bat

Specify the SDK version when running vcvarsall.bat

Chromium requires the 10.0.14393.0 SDK to build. Previous versions don't
have all of the required declarations, and 10.0.15063.0 is buggy (it
includes a file that it doesn't ship with). So, we request 10.0.14393.0
exactly. This will fail if that SDK version is not installed.

The bug for the brokenness of 15063 is here:
https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html

Old SDKs (such as 14393) can be found here:
https://developer.microsoft.com/en-us/windows/downloads/sdk-archive

R=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2814843003
Cr-Commit-Position: refs/heads/master@{#463830}
Committed: https://chromium.googlesource.com/chromium/src/+/b70a415b3e9b474d2de29120f625b48c1b476c0e

[brucedawson, 2017-04-11 21:11:03]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 21:11:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:12:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-04-11 21:15:13]

Description was changed from

==========
Specify the SDK version when running vcvarsall.bat

Chromium requires the 10.0.14393.0 SDK to build. Previous versions don't
have all of the required declarations, and 10.0.15063.0 is buggy (it
includes a file that it doesn't ship with). So, we request 10.0.14393.0
exactly. This will fail if that SDK version is not installed.

R=scottmg@chromium.org
==========

to

==========
Specify the SDK version when running vcvarsall.bat

Chromium requires the 10.0.14393.0 SDK to build. Previous versions don't
have all of the required declarations, and 10.0.15063.0 is buggy (it
includes a file that it doesn't ship with). So, we request 10.0.14393.0
exactly. This will fail if that SDK version is not installed.

The bug for the brokenness of 15063 is here:
https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i...

Old SDKs (such as 14393) can be found here:
https://developer.microsoft.com/en-us/windows/downloads/sdk-archive

R=scottmg@chromium.org
==========

[brucedawson, 2017-04-11 21:19:05]

I think this makes Chromium builds more resilient in the face of Microsoft's
broken 15063 SDK. It selects the 10.0.14393.0 SDK or fails if it is not present.
Whadya think?

It presumably also fails better for users who only have older SDKs, but I
haven't tested that.

[commit-bot: I haz the power, 2017-04-11 21:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:23:13]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-04-11 21:23:19]

https://codereview.chromium.org/2814843003/diff/1/build/toolchain/win/setup_t...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/2814843003/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:146: variables = _LoadEnvFromBat(args)
I don't think this works on VS2015, there was no SDK arg then?

[scottmg, 2017-04-11 21:25:04]

On 2017/04/11 21:23:19, scottmg wrote:
>
https://codereview.chromium.org/2814843003/diff/1/build/toolchain/win/setup_t...
> File build/toolchain/win/setup_toolchain.py (right):
> 
>
https://codereview.chromium.org/2814843003/diff/1/build/toolchain/win/setup_t...
> build/toolchain/win/setup_toolchain.py:146: variables = _LoadEnvFromBat(args)
> I don't think this works on VS2015, there was no SDK arg then?

Wait, I'm going crazy. 12.0 is 2013. 14.0 == 2015.

OK, lgtm, other than we should still delete VS2013 branches of things.

[brucedawson, 2017-04-11 21:40:59]

https://codereview.chromium.org/2814843003/diff/1/build/toolchain/win/setup_t...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/2814843003/diff/1/build/toolchain/win/setup_t...
build/toolchain/win/setup_toolchain.py:146: variables = _LoadEnvFromBat(args)
On 2017/04/11 21:23:19, scottmg wrote:
> I don't think this works on VS2015, there was no SDK arg then?

I tested it on VS 2015. It works fine. It also works on 2017, although I did not
test that as extensively.

What VS 2013 branches? I don't see any references to 2013, or 12.0 or 14.0.

[brucedawson, 2017-04-11 23:14:18]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:15:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:21:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491952458637580, "parent_rev":
"729110102e87635cba60ede6f631d68a374d25e8", "commit_rev":
"b70a415b3e9b474d2de29120f625b48c1b476c0e"}

[commit-bot: I haz the power, 2017-04-11 23:22:18]

Description was changed from

==========
Specify the SDK version when running vcvarsall.bat

Chromium requires the 10.0.14393.0 SDK to build. Previous versions don't
have all of the required declarations, and 10.0.15063.0 is buggy (it
includes a file that it doesn't ship with). So, we request 10.0.14393.0
exactly. This will fail if that SDK version is not installed.

The bug for the brokenness of 15063 is here:
https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i...

Old SDKs (such as 14393) can be found here:
https://developer.microsoft.com/en-us/windows/downloads/sdk-archive

R=scottmg@chromium.org
==========

to

==========
Specify the SDK version when running vcvarsall.bat

Chromium requires the 10.0.14393.0 SDK to build. Previous versions don't
have all of the required declarations, and 10.0.15063.0 is buggy (it
includes a file that it doesn't ship with). So, we request 10.0.14393.0
exactly. This will fail if that SDK version is not installed.

The bug for the brokenness of 15063 is here:
https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i...

Old SDKs (such as 14393) can be found here:
https://developer.microsoft.com/en-us/windows/downloads/sdk-archive

R=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2814843003
Cr-Commit-Position: refs/heads/master@{#463830}
Committed:
https://chromium.googlesource.com/chromium/src/+/b70a415b3e9b474d2de29120f625...
==========

[commit-bot: I haz the power, 2017-04-11 23:22:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b70a415b3e9b474d2de29120f625...