Fix --no-sandbox and --disable-gpu-sandbox on Mali.

Fix --no-sandbox and --disable-gpu-sandbox on Mali.

On Mali GPUs we try to start the sandbox early, before the driver
spawns threads. Because of --no-sandbox, we don't actually start the
sandbox. |gpu_info.sandboxed| will then be false, so at the bottom of
the InitializeAndStartSandbox function we'll try to start the sandbox
again, but at this time the Mali driver will have already started
threads and we'll LOG(FATAL).

Fix by not attempting the second sandbox start when the early one
was attempted.

BUG=707461
TEST=Build for Kevin, add --no-sandbox to the cmdline, UI starts.
TEST=Add --disable-gpu-sandbox to the cmdline, UI starts.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814793007
Cr-Commit-Position: refs/heads/master@{#466212}
Committed: https://chromium.googlesource.com/chromium/src/+/754f1ec2c538c710a8a5bf304643acd89f106db0

[Jorge Lucangeli Obes, 2017-04-14 17:34:20]

Description was changed from

==========
Fix --no-sandbox and --disable-gpu-sandbox on Mali.

On Mali GPUs we try to start the sandbox early, before the driver
spawns threads. Because of --no-sandbox, we don't actually start the
sandbox. |gpu_info.sandboxed| will then be false, so at the bottom of
the InitializeAndStartSandbox function we'll try to start the sandbox
again, but at this time the Mali driver will have already started
threads and we'll LOG(FATAL).

Fix by not attempting the second sandbox start when the early one
was attempted.

BUG=707461
TEST=Build for Kevin, add --no-sandbox to the cmdline, UI starts.
TEST=Add --disable-gpu-sandbox to the cmdline, UI starts.
==========

to

==========
Fix --no-sandbox and --disable-gpu-sandbox on Mali.

On Mali GPUs we try to start the sandbox early, before the driver
spawns threads. Because of --no-sandbox, we don't actually start the
sandbox. |gpu_info.sandboxed| will then be false, so at the bottom of
the InitializeAndStartSandbox function we'll try to start the sandbox
again, but at this time the Mali driver will have already started
threads and we'll LOG(FATAL).

Fix by not attempting the second sandbox start when the early one
was attempted.

BUG=707461
TEST=Build for Kevin, add --no-sandbox to the cmdline, UI starts.
TEST=Add --disable-gpu-sandbox to the cmdline, UI starts.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Jorge Lucangeli Obes, 2017-04-14 17:34:59]

jorgelo@chromium.org changed reviewers:
+ marcheu@chromium.org

[Jorge Lucangeli Obes, 2017-04-14 17:36:56]

The CQ bit was checked by jorgelo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 17:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 18:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:34:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jorge Lucangeli Obes, 2017-04-20 18:12:52]

Ping? We should probably fix this.

[marcheu, 2017-04-20 19:10:34]

lgtm

[Jorge Lucangeli Obes, 2017-04-20 19:18:33]

The CQ bit was checked by jorgelo@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 19:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:28:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jorge Lucangeli Obes, 2017-04-20 19:33:03]

jorgelo@chromium.org changed reviewers:
+ kbr@chromium.org

[Jorge Lucangeli Obes, 2017-04-20 19:33:03]

Ken for GPU owners.

[Ken Russell (switch to Gerrit), 2017-04-20 22:15:44]

lgtm

[Jorge Lucangeli Obes, 2017-04-21 01:23:34]

The CQ bit was checked by jorgelo@chromium.org

[commit-bot: I haz the power, 2017-04-21 01:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 01:27:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492737814442240, "parent_rev":
"480f457f6939eade256dc987fd740452ef5912de", "commit_rev":
"754f1ec2c538c710a8a5bf304643acd89f106db0"}

[commit-bot: I haz the power, 2017-04-21 01:27:17]

Description was changed from

==========
Fix --no-sandbox and --disable-gpu-sandbox on Mali.

On Mali GPUs we try to start the sandbox early, before the driver
spawns threads. Because of --no-sandbox, we don't actually start the
sandbox. |gpu_info.sandboxed| will then be false, so at the bottom of
the InitializeAndStartSandbox function we'll try to start the sandbox
again, but at this time the Mali driver will have already started
threads and we'll LOG(FATAL).

Fix by not attempting the second sandbox start when the early one
was attempted.

BUG=707461
TEST=Build for Kevin, add --no-sandbox to the cmdline, UI starts.
TEST=Add --disable-gpu-sandbox to the cmdline, UI starts.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix --no-sandbox and --disable-gpu-sandbox on Mali.

On Mali GPUs we try to start the sandbox early, before the driver
spawns threads. Because of --no-sandbox, we don't actually start the
sandbox. |gpu_info.sandboxed| will then be false, so at the bottom of
the InitializeAndStartSandbox function we'll try to start the sandbox
again, but at this time the Mali driver will have already started
threads and we'll LOG(FATAL).

Fix by not attempting the second sandbox start when the early one
was attempted.

BUG=707461
TEST=Build for Kevin, add --no-sandbox to the cmdline, UI starts.
TEST=Add --disable-gpu-sandbox to the cmdline, UI starts.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814793007
Cr-Commit-Position: refs/heads/master@{#466212}
Committed:
https://chromium.googlesource.com/chromium/src/+/754f1ec2c538c710a8a5bf304643...
==========

[commit-bot: I haz the power, 2017-04-21 01:27:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/754f1ec2c538c710a8a5bf304643...