Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2814793005: Mark the network bubble task as MayBlock to prevent it from crashing the browser. (Closed)

Created:
3 years, 8 months ago by pastarmovj
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark the network bubble task as MayBlock to prevent it from crashing the browser. The call to WTSQuerySessionInformation can take arbitrary long time and thus can crash the browser when it takes more then expected. This even if not crashing the browser also was stalling the FILE thread. BUG=706737 TEST=Wait and see if crash rate falls. Review-Url: https://codereview.chromium.org/2814793005 Cr-Commit-Position: refs/heads/master@{#464388} Committed: https://chromium.googlesource.com/chromium/src/+/4901e4ce3bcd49618d8b788f1a67c5276a4147fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
pastarmovj
Hi Jochen, can you please take a look at this CL? Thanks, Julian
3 years, 8 months ago (2017-04-13 11:53:06 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-13 11:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814793005/1
3 years, 8 months ago (2017-04-13 12:17:26 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 13:03:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4901e4ce3bcd49618d8b788f1a67...

Powered by Google App Engine
This is Rietveld 408576698