Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: ios/chrome/search_widget_extension/BUILD.gn

Issue 2814783003: Rename widget to search widget and use new bundleid to always build. (Closed)
Patch Set: seems I didn't actually delete widget_view_controller... Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/app/BUILD.gn ('k') | ios/chrome/search_widget_extension/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/search_widget_extension/BUILD.gn
diff --git a/ios/chrome/widget_extension/BUILD.gn b/ios/chrome/search_widget_extension/BUILD.gn
similarity index 71%
rename from ios/chrome/widget_extension/BUILD.gn
rename to ios/chrome/search_widget_extension/BUILD.gn
index 31fed23e3cbf7bd3c8c0defd102937b8dcac5d82..80a585f974b10b5e85b0f0199217989e69e6814f 100644
--- a/ios/chrome/widget_extension/BUILD.gn
+++ b/ios/chrome/search_widget_extension/BUILD.gn
@@ -14,17 +14,17 @@ tweak_info_plist("tweak_info_plist") {
compile_plist("entitlements") {
format = "xml1"
substitutions = [ "IOS_BUNDLE_ID_PREFIX=$ios_app_bundle_id_prefix" ]
- output_name = "$target_gen_dir/today_extension.appex.entitlements"
+ output_name = "$target_gen_dir/search_widget_extension.appex.entitlements"
plist_templates =
- [ "entitlements/external/widget_extension.appex.entitlements" ]
+ [ "entitlements/external/search_widget_extension.appex.entitlements" ]
}
-ios_appex_bundle("widget_extension") {
+ios_appex_bundle("search_widget_extension") {
sources = [
- "widget_view.h",
- "widget_view.mm",
- "widget_view_controller.h",
- "widget_view_controller.mm",
+ "search_widget_view.h",
+ "search_widget_view.mm",
+ "search_widget_view_controller.h",
+ "search_widget_view_controller.mm",
]
deps = [
@@ -52,11 +52,7 @@ ios_appex_bundle("widget_extension") {
extra_substitutions = [
"CHROME_CHANNEL_SCHEME=$url_channel_scheme",
"CHROMIUM_SHORT_NAME=$chromium_short_name",
-
- # The widget_extension and today_extension are using the same provisioning
- # profile during development work.
- # TODO(crbug.com/682238) : Request provisioning profile if widget is kept.
- "WIDGET_EXTENSION_BUNDLE_ID=$chromium_bundle_id.TodayExtension",
+ "WIDGET_EXTENSION_BUNDLE_ID=$chromium_bundle_id.SearchTodayExtension",
]
configs += [ "//build/config/compiler:enable_arc" ]
« no previous file with comments | « ios/chrome/app/BUILD.gn ('k') | ios/chrome/search_widget_extension/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698