Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: ios/chrome/app/BUILD.gn

Issue 2814783003: Rename widget to search widget and use new bundleid to always build. (Closed)
Patch Set: seems I didn't actually delete widget_view_controller... Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/build/chrome_build.gni ('k') | ios/chrome/search_widget_extension/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/app/BUILD.gn
diff --git a/ios/chrome/app/BUILD.gn b/ios/chrome/app/BUILD.gn
index 3704c77b0296aea85d049e3cd4b43f460964011f..4e36ae066834834cdd10b12c91b0318f6dc4e74d 100644
--- a/ios/chrome/app/BUILD.gn
+++ b/ios/chrome/app/BUILD.gn
@@ -274,8 +274,8 @@ ios_app_bundle("chrome") {
if (ios_enable_today_extension) {
deps += [ ":today_extension_bundle" ]
}
- if (ios_enable_widget_extension) {
- deps += [ ":widget_extension_bundle" ]
+ if (ios_enable_search_widget_extension) {
+ deps += [ ":search_widget_extension_bundle" ]
}
if (ios_enable_share_extension) {
deps += [ ":share_extension_bundle" ]
@@ -314,22 +314,16 @@ if (current_toolchain == default_toolchain) {
}
}
- if (ios_enable_widget_extension) {
- bundle_data("widget_extension_bundle") {
+ if (ios_enable_search_widget_extension) {
+ bundle_data("search_widget_extension_bundle") {
public_deps = [
- "//ios/chrome/widget_extension",
+ "//ios/chrome/search_widget_extension",
]
sources = [
- "$root_out_dir/widget_extension.appex",
+ "$root_out_dir/search_widget_extension.appex",
]
-
- # The output is renamed today_extension.appex so that signing in canary
- # works and clobbering is not necessary when switching between this
- # extension and the today extension.
- # TODO(crbug.com/682230) : Rename this when widget gets its own
- # mobileprovision.
outputs = [
- "{{bundle_plugins_dir}}/today_extension.appex",
+ "{{bundle_plugins_dir}}/{{source_file_part}}",
]
}
}
« no previous file with comments | « ios/build/chrome_build.gni ('k') | ios/chrome/search_widget_extension/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698