Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 2814743011: Revert of Avoid cross thread malloc / free pair of IOBuffer on the simple cache (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid cross thread malloc / free pair of IOBuffer on the simple cache (patchset #2 id:20001 of https://codereview.chromium.org/2815563002/ ) Reason for revert: Another large memory reduction seems to land in the same batch of the performance dashboard job, and it hid the improvement of this CL. Revert this for now and will reland later. Original issue's description: > Avoid cross thread malloc/free pair of IOBuffer on the simple cache > > This CL removes a cross thread malloc/free pair from simple disk cache backend. > > After a PostTaskAndReply change in http://crrev.com/e5de8d551e80115b, it > destroys |task| part of the given tasks on the target thread, and that > introduced a number of cross thread malloc/free pairs around net::IOBuffer. > The cross thread malloc/free pair increased the apparent size of memory > usage on some Android perf bots by 2~3%, that is likely due to thread > specific free list caches. > > BUG=708644 > > Review-Url: https://codereview.chromium.org/2815563002 > Cr-Commit-Position: refs/heads/master@{#464338} > Committed: https://chromium.googlesource.com/chromium/src/+/1714b61635cc8207647b1a9857e8042fbb833025 TBR=pmeenan@chromium.org,primiano@chromium.org,jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708644 Review-Url: https://codereview.chromium.org/2814743011 Cr-Commit-Position: refs/heads/master@{#464551} Committed: https://chromium.googlesource.com/chromium/src/+/9fcfc8861ae30d5f1f5acf2d4cc0237f7f4e4f59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M net/disk_cache/simple/simple_entry_impl.h View 1 chunk +1 line, -5 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tzik
Created Revert of Avoid cross thread malloc / free pair of IOBuffer on the simple ...
3 years, 8 months ago (2017-04-13 21:29:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814743011/1
3 years, 8 months ago (2017-04-13 21:30:26 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 21:32:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9fcfc8861ae30d5f1f5acf2d4cc0...

Powered by Google App Engine
This is Rietveld 408576698