Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2814743009: Make adjustable large cursor enabled by default (Closed)

Created:
3 years, 8 months ago by yawano
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni, oshima, Dan Beam
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, asvitkine+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, je_julie, yuzo+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, lpalmaro_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make adjustable large cursor enabled by default - Remove flag to enable adjustable large cursor and make it enabled by default. BUG=591493, 700256, 700260 TEST=Go to accessibility section of settings, and confirm that adjustable large cursor is enabled by default. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2814743009 Cr-Commit-Position: refs/heads/master@{#466271} Committed: https://chromium.googlesource.com/chromium/src/+/92daff58d9c46d9ba81d43bb4ddf91bcfe82d3c0

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -55 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/display/cursor_window_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/cursor_window_controller.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.html View 1 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
yawano
PTAL oshima@: - files under ash/ - about_flags.cc - flag_description.cc dmazzoni@: - c/b/chromeos/accessibility/accessibility_manager.cc dbeam@: - ...
3 years, 8 months ago (2017-04-13 01:03:11 UTC) #3
dmazzoni
lgtm
3 years, 8 months ago (2017-04-17 05:08:00 UTC) #4
oshima
lgtm
3 years, 8 months ago (2017-04-17 14:50:24 UTC) #5
yawano
Thank you for the review! dbeam@: ping.
3 years, 8 months ago (2017-04-17 23:07:57 UTC) #6
Dan Beam
lgtm
3 years, 8 months ago (2017-04-19 17:20:11 UTC) #7
yawano
On 2017/04/19 17:20:11, Dan Beam wrote: > lgtm Thank you!
3 years, 8 months ago (2017-04-21 00:48:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814743009/1
3 years, 8 months ago (2017-04-21 00:48:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/417124)
3 years, 8 months ago (2017-04-21 00:51:56 UTC) #12
yawano
Rebased.
3 years, 8 months ago (2017-04-21 05:24:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814743009/20001
3 years, 8 months ago (2017-04-21 05:25:02 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 06:34:49 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92daff58d9c46d9ba81d43bb4ddf...

Powered by Google App Engine
This is Rietveld 408576698