Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: chrome/browser/search_engines/template_url_service_sync_unittest.cc

Issue 2814743006: Refactoring after comments in https://codereview.chromium.org/2639153002 (Closed)
Patch Set: Fixed after review, round 2 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_sync_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_sync_unittest.cc b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
index 0313e33a1dc6ed233d31d384b660ba67810b30a8..93d5dbe397c4577e4a7c24dc873d22408b32acdd 100644
--- a/chrome/browser/search_engines/template_url_service_sync_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
@@ -442,8 +442,9 @@ TEST_F(TemplateURLServiceSyncTest, GetAllSyncDataWithSearchOverrideExtension) {
std::unique_ptr<TemplateURLData> extension =
GenerateDummyTemplateURLData("extension");
auto ext_dse = base::MakeUnique<TemplateURL>(
- *extension, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION);
- test_util_a_->AddExtensionControlledTURL(std::move(ext_dse), "ext", true);
+ *extension, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION, "ext", Time(),
+ true);
+ test_util_a_->AddExtensionControlledTURL(std::move(ext_dse));
const TemplateURL* ext_turl = model()->GetDefaultSearchProvider();
EXPECT_TRUE(model()->IsExtensionControlledDefaultSearch());
@@ -1759,8 +1760,9 @@ TEST_F(TemplateURLServiceSyncTest, SyncWithExtensionDefaultSearch) {
std::unique_ptr<TemplateURLData> extension =
GenerateDummyTemplateURLData("extensiondefault");
auto ext_dse = base::MakeUnique<TemplateURL>(
- *extension, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION);
- test_util_a_->AddExtensionControlledTURL(std::move(ext_dse), "ext", true);
+ *extension, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION, "ext", Time(),
+ true);
+ test_util_a_->AddExtensionControlledTURL(std::move(ext_dse));
const TemplateURL* dsp_turl = model()->GetDefaultSearchProvider();
EXPECT_TRUE(model()->IsExtensionControlledDefaultSearch());
@@ -1811,9 +1813,10 @@ TEST_F(TemplateURLServiceSyncTest, ExtensionAndNormalEngineConflict) {
std::unique_ptr<TemplateURLData> extension =
GenerateDummyTemplateURLData("common_keyword");
auto ext_dse = base::MakeUnique<TemplateURL>(
- *extension, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION);
+ *extension, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION, "ext", Time(),
+ true);
const TemplateURL* extension_turl =
- test_util_a_->AddExtensionControlledTURL(std::move(ext_dse), "ext", true);
+ test_util_a_->AddExtensionControlledTURL(std::move(ext_dse));
EXPECT_TRUE(model()->IsExtensionControlledDefaultSearch());
EXPECT_EQ(extension_turl, model()->GetTemplateURLForKeyword(kCommonKeyword));

Powered by Google App Engine
This is Rietveld 408576698