Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2814743006: Refactoring after comments in https://codereview.chromium.org/2639153002 (Closed)
Patch Set: Fixed after review, round 2 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_service_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
index 6f607b1a05648558efbdae9270cb41407315e51a..a40ff4ccb52e03329ea0ee84d3ad961c097af1c2 100644
--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
@@ -228,19 +228,17 @@ void SettingsOverridesAPI::RegisterSearchProvider(
const SettingsOverrides* settings = SettingsOverrides::Get(extension);
DCHECK(settings);
DCHECK(settings->search_engine);
- auto info =
- base::MakeUnique<TemplateURL::AssociatedExtensionInfo>(extension->id());
- info->wants_to_be_default_engine = settings->search_engine->is_default;
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile_);
- info->install_time = prefs->GetInstallTime(extension->id());
std::string install_parameter = prefs->GetInstallParam(extension->id());
std::unique_ptr<TemplateURLData> data = ConvertSearchProvider(
profile_->GetPrefs(), *settings->search_engine, install_parameter);
auto turl = base::MakeUnique<TemplateURL>(
- *data, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION);
+ *data, TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION, extension->id(),
+ prefs->GetInstallTime(extension->id()),
+ settings->search_engine->is_default);
- url_service_->AddExtensionControlledTURL(std::move(turl), std::move(info));
+ url_service_->Add(std::move(turl));
if (settings->search_engine->is_default) {
// Override current DSE pref to have extension overriden value.
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_service_sync_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698