Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2814723002: Measure SVGPathElement.getPathSegAtLength usage (Closed)

Created:
3 years, 8 months ago by Shanmuga Pandi
Modified:
3 years, 8 months ago
Reviewers:
Ilya Sherman, fs, foolip
CC:
chromium-reviews, krit, rwlbuis, fs, fmalita+watch_chromium.org, asvitkine+watch_chromium.org, blink-reviews, gyuyoung2, blink-reviews-frames_chromium.org, kouhei+svg_chromium.org, Stephen Chennney, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure SVGPathElement.getPathSegAtLength usage This interface removed from Spec. Measuring this usage will be useful to remove this. BUG=669498 Review-Url: https://codereview.chromium.org/2814723002 Cr-Commit-Position: refs/heads/master@{#463948} Committed: https://chromium.googlesource.com/chromium/src/+/89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Shanmuga Pandi
PTAL!!
3 years, 8 months ago (2017-04-11 14:07:59 UTC) #3
foolip
lgtm
3 years, 8 months ago (2017-04-11 14:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814723002/1
3 years, 8 months ago (2017-04-11 14:20:27 UTC) #6
foolip
FWIW, there are only 15 hits for "getPathSegAtLength" in httparchive, making it quite likely that ...
3 years, 8 months ago (2017-04-11 14:22:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/407909)
3 years, 8 months ago (2017-04-11 14:30:06 UTC) #9
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-11 21:37:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814723002/1
3 years, 8 months ago (2017-04-12 04:39:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/89b08748a1f0bef747dd1b15f3e80ad9dc70c7b9
3 years, 8 months ago (2017-04-12 07:50:31 UTC) #15
Shanmuga Pandi
On 2017/04/11 14:22:58, foolip_UTC7 wrote: > FWIW, there are only 15 hits for "getPathSegAtLength" in ...
3 years, 8 months ago (2017-04-13 10:31:09 UTC) #16
foolip
3 years, 8 months ago (2017-04-13 10:41:16 UTC) #17
Message was sent while issue was closed.
On 2017/04/13 10:31:09, Shanmuga Pandi wrote:
> On 2017/04/11 14:22:58, foolip_UTC7 wrote:
> > FWIW, there are only 15 hits for "getPathSegAtLength" in httparchive, making
> it
> > quite likely that usage will be very low.
> > 
> > Nevertheless, there's no particular hurry here, so waiting for use counter
> data
> > is fine. If you'd like, however, I think looking at the httparchive usage
and
> > deprecating with a tentative removal date would be fine. Then we just make
> sure
> > to check the usage from the stable channel before actually going through
with
> > the removal.
> 
> Thanks foolip.
> Shall I post Intent to Deprecate to blink-dev without use counter ?

Yes, in this case I think it's OK to proceed with the deprecation and decide a
tentative milestone for removal before we have the use counter data. So that we
have the data before the removal hits stable, I think at least two milestones of
deprecation are necessary. So if you suggest to deprecate in M60, remove in M62.

Powered by Google App Engine
This is Rietveld 408576698