Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2814703003: [Mac] Use templated images for bookmark menu (Closed)

Created:
3 years, 8 months ago by lgrey
Modified:
3 years, 8 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Use templated images for bookmark menu This gives us light icons in macOS "Use dark menu bar and Dock" mode without manual intervention. BUG=660551 Review-Url: https://codereview.chromium.org/2814703003 Cr-Commit-Position: refs/heads/master@{#463666} Committed: https://chromium.googlesource.com/chromium/src/+/71125ff12bb0d87b36c81a2783223489bd062a42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
lgrey
PTAL :)
3 years, 8 months ago (2017-04-11 16:46:35 UTC) #2
Elly Fong-Jones
lgtm
3 years, 8 months ago (2017-04-11 16:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814703003/1
3 years, 8 months ago (2017-04-11 16:50:45 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:26:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71125ff12bb0d87b36c81a278322...

Powered by Google App Engine
This is Rietveld 408576698