Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2814683003: Pass through the response code and headers in Background Fetch (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
harkness
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org, David Trainor- moved to gerrit
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass through the response code and headers in Background Fetch Following this CL, Background Fetch responses will include the response code and headers as provided by the download manager. We don't yet support the `backgroundfetchfail` event or handle CORS, but those can now be implemented in follow-up CLs. BUG=709489 Review-Url: https://codereview.chromium.org/2814683003 Cr-Commit-Position: refs/heads/master@{#464119} Committed: https://chromium.googlesource.com/chromium/src/+/0b6bb8eb5aa2c306f7ad88a746bbec775c18b103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -83 lines) Patch
M content/browser/background_fetch/background_fetch_data_manager.cc View 1 chunk +22 lines, -31 lines 0 comments Download
M content/browser/background_fetch/background_fetch_job_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/background_fetch/background_fetch_request_info.h View 4 chunks +16 lines, -4 lines 0 comments Download
M content/browser/background_fetch/background_fetch_request_info.cc View 4 chunks +32 lines, -6 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 2 chunks +36 lines, -10 lines 0 comments Download
M content/browser/background_fetch/background_fetch_test_base.h View 3 chunks +37 lines, -5 lines 0 comments Download
M content/browser/background_fetch/background_fetch_test_base.cc View 7 chunks +62 lines, -24 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Peter Beverloo
+harkness for review +dtrainor FYI
3 years, 8 months ago (2017-04-11 18:16:38 UTC) #2
harkness
lgtm
3 years, 8 months ago (2017-04-12 10:31:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814683003/1
3 years, 8 months ago (2017-04-12 16:06:55 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:55:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b6bb8eb5aa2c306f7ad88a746bb...

Powered by Google App Engine
This is Rietveld 408576698