Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2814683002: [builtins] Implement %TypedArray%.prototype.map in the CSA (Closed)

Created:
3 years, 8 months ago by Tobias Tebbi
Modified:
3 years, 7 months ago
Reviewers:
mvstanton, danno
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Implement %TypedArray%.prototype.map in the CSA R=danno@chromium.org Review-Url: https://codereview.chromium.org/2814683002 Cr-Commit-Position: refs/heads/master@{#45380} Committed: https://chromium.googlesource.com/v8/v8/+/d4f80f4c0117456e87099498512ba51100cbdc79

Patch Set 1 #

Patch Set 2 : removed unused parameter and disabled experimental flag #

Patch Set 3 : Rebased. #

Patch Set 4 : added spec comments #

Total comments: 1

Patch Set 5 : switched to BIND macro #

Total comments: 2

Patch Set 6 : addressed comments #

Patch Set 7 : Rebased. #

Patch Set 8 : changed length check to assertion #

Patch Set 9 : added TODO #

Patch Set 10 : Rebased. #

Patch Set 11 : undo flag change #

Patch Set 12 : added todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -83 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-array-gen.cc View 1 2 3 4 5 6 7 8 9 10 9 chunks +92 lines, -13 lines 0 comments Download
M src/builtins/builtins-definitions.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-typedarray.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -69 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 1 chunk +64 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Tobias Tebbi
3 years, 8 months ago (2017-04-11 12:44:03 UTC) #1
Camillo Bruni
https://codereview.chromium.org/2814683002/diff/60001/src/builtins/builtins-array-gen.cc File src/builtins/builtins-array-gen.cc (right): https://codereview.chromium.org/2814683002/diff/60001/src/builtins/builtins-array-gen.cc#newcode194 src/builtins/builtins-array-gen.cc:194: Bind(&fast); drive-by-comment: Could you upgrade your implementation to use ...
3 years, 8 months ago (2017-04-11 13:16:06 UTC) #3
Tobias Tebbi
3 years, 8 months ago (2017-04-20 15:59:03 UTC) #6
Tobias Tebbi
3 years, 8 months ago (2017-04-20 16:00:02 UTC) #8
danno
lgtm with comments https://codereview.chromium.org/2814683002/diff/80001/src/builtins/builtins-array-gen.cc File src/builtins/builtins-array-gen.cc (right): https://codereview.chromium.org/2814683002/diff/80001/src/builtins/builtins-array-gen.cc#newcode159 src/builtins/builtins-array-gen.cc:159: Node* A = TypedArraySpeciesCreateByLength(context(), o(), len_); ...
3 years, 8 months ago (2017-04-24 16:11:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814683002/120001
3 years, 8 months ago (2017-04-25 11:04:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_ng/builds/4869)
3 years, 8 months ago (2017-04-25 11:15:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814683002/220001
3 years, 7 months ago (2017-05-17 14:50:17 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 15:27:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/v8/v8/+/d4f80f4c0117456e87099498512ba51100c...

Powered by Google App Engine
This is Rietveld 408576698