Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/Source/platform/FrameViewBase.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/FrameViewBase.h
diff --git a/third_party/WebKit/Source/platform/FrameViewBase.h b/third_party/WebKit/Source/platform/FrameViewBase.h
index f79ee27fe1323674388887ba6cd10fca19905dfe..d059a0fcaece0ad56aeb6a185a812f7ceb489360 100644
--- a/third_party/WebKit/Source/platform/FrameViewBase.h
+++ b/third_party/WebKit/Source/platform/FrameViewBase.h
@@ -36,9 +36,7 @@
namespace blink {
-class CullRect;
class Event;
-class GraphicsContext;
// The FrameViewBase class serves as a base class for FrameView, Scrollbar, and
// PluginView.
@@ -63,17 +61,10 @@ class PLATFORM_EXPORT FrameViewBase
frame_rect_ = frame_rect;
}
const IntRect& FrameRect() const { return frame_rect_; }
- IntRect BoundsRect() const { return IntRect(0, 0, Width(), Height()); }
void Resize(int w, int h) { SetFrameRect(IntRect(X(), Y(), w, h)); }
void Resize(const IntSize& s) { SetFrameRect(IntRect(Location(), s)); }
- virtual void Paint(GraphicsContext&, const CullRect&) const {}
- void Invalidate() { InvalidateRect(BoundsRect()); }
- virtual void InvalidateRect(const IntRect&) = 0;
-
- virtual void Show() {}
- virtual void Hide() {}
bool IsSelfVisible() const {
return self_visible_;
} // Whether or not we have been explicitly marked as visible or not.
« no previous file with comments | « third_party/WebKit/Source/core/plugins/PluginView.h ('k') | third_party/WebKit/Source/platform/scroll/Scrollbar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698