Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/plugins/PluginView.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/plugins/PluginView.h
diff --git a/third_party/WebKit/Source/core/plugins/PluginView.h b/third_party/WebKit/Source/core/plugins/PluginView.h
index 0a1113ca0950fe86d231c3f336ea9f9f2b470d70..7fcc3238039040e5e60ad51ff39b94d191a8d4a7 100644
--- a/third_party/WebKit/Source/core/plugins/PluginView.h
+++ b/third_party/WebKit/Source/core/plugins/PluginView.h
@@ -29,24 +29,36 @@
#define PluginView_h
#include "core/CoreExport.h"
-#include "platform/FrameViewBase.h"
+#include "core/frame/FrameOrPlugin.h"
+#include "platform/geometry/IntRect.h"
#include "platform/scroll/ScrollTypes.h"
#include "public/platform/WebFocusType.h"
#include "v8/include/v8.h"
#include "wtf/text/WTFString.h"
namespace blink {
-class WebLayer;
-}
-
-namespace blink {
+class Event;
+class FrameView;
class ResourceResponse;
+class WebLayer;
-class CORE_EXPORT PluginView : public FrameViewBase {
+// TODO(joelhockey): Remove this class.
+// The only implementation of this class is web/WebPluginContainerImpl.
+// It can be used directly.
+class CORE_EXPORT PluginView : public FrameOrPlugin {
public:
- bool IsPluginView() const final { return true; }
- virtual void SetFocused(bool, WebFocusType) {}
+ virtual ~PluginView() {}
+
+ virtual void SetParent(FrameView*) = 0;
+ virtual FrameView* Parent() const = 0;
+ virtual void SetParentVisible(bool) = 0;
+ virtual void SetFocused(bool, WebFocusType) = 0;
+ virtual void FrameRectsChanged() = 0;
+ virtual void GeometryMayHaveChanged() = 0;
+ virtual void HandleEvent(Event*) = 0;
+ virtual void EventListenersRemoved() = 0;
+ virtual bool IsPluginContainer() const { return false; }
virtual WebLayer* PlatformLayer() const { return 0; }
virtual v8::Local<v8::Object> ScriptableObject(v8::Isolate*) {
@@ -62,17 +74,8 @@ class CORE_EXPORT PluginView : public FrameViewBase {
virtual void UpdateAllLifecyclePhases() {}
virtual void InvalidatePaintIfNeeded() {}
-
- protected:
- PluginView() : FrameViewBase() {}
};
-DEFINE_TYPE_CASTS(PluginView,
- FrameViewBase,
- frameViewBase,
- frameViewBase->IsPluginView(),
- frameViewBase.IsPluginView());
-
} // namespace blink
#endif // PluginView_h
« no previous file with comments | « third_party/WebKit/Source/core/paint/PartPainter.cpp ('k') | third_party/WebKit/Source/platform/FrameViewBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698