third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h - Issue 2814643003: Remove FrameViewBase as base class of PluginView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)

Patch Set: Address final comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

index 2bda3b5c68f68642b59bda16d9d5817a261636f0..2cd3ff21637ef786fd08e9d0806acb63cb7e8468 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

@@ -34,6 +34,7 @@ namespace blink {

class ExceptionState;

class Frame;

+class FrameOrPlugin;

class FrameViewBase;

class LayoutPart;

@@ -105,7 +106,7 @@ class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,

bool replace_current_item);

bool IsKeyboardFocusable() const override;

- void DisposeWidgetSoon(FrameViewBase*);

+ void DisposeFrameOrPluginSoon(FrameOrPlugin*);

void FrameOwnerPropertiesChanged();

private: