Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 16 matching lines...) Expand all
27 #include "core/html/HTMLElement.h" 27 #include "core/html/HTMLElement.h"
28 #include "platform/heap/Handle.h" 28 #include "platform/heap/Handle.h"
29 #include "platform/scroll/ScrollTypes.h" 29 #include "platform/scroll/ScrollTypes.h"
30 #include "platform/weborigin/SecurityPolicy.h" 30 #include "platform/weborigin/SecurityPolicy.h"
31 #include "platform/wtf/HashCountedSet.h" 31 #include "platform/wtf/HashCountedSet.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class ExceptionState; 35 class ExceptionState;
36 class Frame; 36 class Frame;
37 class FrameOrPlugin;
37 class FrameViewBase; 38 class FrameViewBase;
38 class LayoutPart; 39 class LayoutPart;
39 40
40 class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement, 41 class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,
41 public FrameOwner { 42 public FrameOwner {
42 USING_GARBAGE_COLLECTED_MIXIN(HTMLFrameOwnerElement); 43 USING_GARBAGE_COLLECTED_MIXIN(HTMLFrameOwnerElement);
43 44
44 public: 45 public:
45 ~HTMLFrameOwnerElement() override; 46 ~HTMLFrameOwnerElement() override;
46 47
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 99
99 protected: 100 protected:
100 HTMLFrameOwnerElement(const QualifiedName& tag_name, Document&); 101 HTMLFrameOwnerElement(const QualifiedName& tag_name, Document&);
101 void SetSandboxFlags(SandboxFlags); 102 void SetSandboxFlags(SandboxFlags);
102 103
103 bool LoadOrRedirectSubframe(const KURL&, 104 bool LoadOrRedirectSubframe(const KURL&,
104 const AtomicString& frame_name, 105 const AtomicString& frame_name,
105 bool replace_current_item); 106 bool replace_current_item);
106 bool IsKeyboardFocusable() const override; 107 bool IsKeyboardFocusable() const override;
107 108
108 void DisposeWidgetSoon(FrameViewBase*); 109 void DisposeFrameOrPluginSoon(FrameOrPlugin*);
109 void FrameOwnerPropertiesChanged(); 110 void FrameOwnerPropertiesChanged();
110 111
111 private: 112 private:
112 // Intentionally private to prevent redundant checks when the type is 113 // Intentionally private to prevent redundant checks when the type is
113 // already HTMLFrameOwnerElement. 114 // already HTMLFrameOwnerElement.
114 bool IsLocal() const final { return true; } 115 bool IsLocal() const final { return true; }
115 bool IsRemote() const final { return false; } 116 bool IsRemote() const final { return false; }
116 117
117 bool IsFrameOwnerElement() const final { return true; } 118 bool IsFrameOwnerElement() const final { return true; }
118 119
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 168
168 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement, 169 DEFINE_TYPE_CASTS(HTMLFrameOwnerElement,
169 FrameOwner, 170 FrameOwner,
170 owner, 171 owner,
171 owner->IsLocal(), 172 owner->IsLocal(),
172 owner.IsLocal()); 173 owner.IsLocal());
173 174
174 } // namespace blink 175 } // namespace blink
175 176
176 #endif // HTMLFrameOwnerElement_h 177 #endif // HTMLFrameOwnerElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698