Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2814633006: Surface synchronization: Immediately activate late arriving CompositorFrames (Closed)

Created:
3 years, 8 months ago by Fady Samuel
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Surface synchronization: Immediately activate late arriving CompositorFrames A dependent CompositorFrame may arrive late (after the deadline has hit and the parent CompositorFrame activated). This CL tracks late arrivals (until the next deadline hits) and immediately activates them despite dependencies. This reduces latency and guttering of browser UI in Mus+Ash because this prevents browser UI from blocking for too long on the renderer. BUG=672962, 710517 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2814633006 Cr-Commit-Position: refs/heads/master@{#464122} Committed: https://chromium.googlesource.com/chromium/src/+/35927811f7b1d449675cbad2de6952844a93ef3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M cc/surfaces/surface_dependency_tracker.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/surfaces/surface_dependency_tracker.cc View 4 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Fady Samuel
3 years, 8 months ago (2017-04-12 00:15:34 UTC) #4
piman
lgtm
3 years, 8 months ago (2017-04-12 19:21:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814633006/1
3 years, 8 months ago (2017-04-12 19:22:53 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 20:00:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35927811f7b1d449675cbad2de69...

Powered by Google App Engine
This is Rietveld 408576698